Closed Bug 817932 Opened 7 years ago Closed 7 years ago

Intermittent failure in browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_openlocation.js | The correct URL should be loaded via the open location dialog - Got about:privatebrowsing, expected about:logo

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

(This happens only on the Birch branch for now)

https://tbpl.mozilla.org/php/getParsedLog.php?id=17570433&tree=Birch

This is basically a reincarnation of what attachment 687615 [details] [diff] [review] fixed for non-private windows.  For private windows, we just load about:privatebrowsing as the home page, and there is no way to override that.
Attached patch Patch (v1)Splinter Review
I guess we should resort to the common hack of ignoring unrelated loads.  This replaces an explicit failure scenario with a timeout, which I guess isn't so terrible, compared to the alternative.
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #688091 - Flags: review?(josh)
Comment on attachment 688091 [details] [diff] [review]
Patch (v1)

Timeouts are ok by me.
Attachment #688091 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/5cd6a612bc8e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.