817957 - [AccessFu] AccessFu.css and content-script.js are duplicated

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Mike Hommey [:glandium]]

Duplicates 654 bytes:
  modules/accessibility/AccessFu.css
  chrome/toolkit/content/global/accessibility/AccessFu.css

Duplicates 8490 bytes:
  modules/accessibility/content-script.js
  chrome/toolkit/content/global/accessibility/content-script.js

Looking at the tree, it seems these files are only used from a chrome url. They are installed in chrome because of jar.mn and under modules because of Makefile.in.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Deduplicate AccessFu.css and content-script.js

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to Mike Hommey [:glandium] from comment #0)
> Duplicates 654 bytes:
>   modules/accessibility/AccessFu.css
>   chrome/toolkit/content/global/accessibility/AccessFu.css
> 
> Duplicates 8490 bytes:
>   modules/accessibility/content-script.js
>   chrome/toolkit/content/global/accessibility/content-script.js
> 
> Looking at the tree, it seems these files are only used from a chrome url.
> They are installed in chrome because of jar.mn and under modules because of
> Makefile.in.

I don't know our build system well at all. Is what you say true for all builds including b2g and android?

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 688145 [details] [diff] [review]
Deduplicate AccessFu.css and content-script.js

r=me if the answer is yes (see above comment)

Thanks.

Comment 4

[Mike Hommey [:glandium]]

(In reply to David Bolter [:davidb] from comment #2)
> I don't know our build system well at all. Is what you say true for all
> builds including b2g and android?

It is.

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96995cdf0682

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/96995cdf0682