817989 - [CONTACTS] Is not possible to save a contact with a very long phone number

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Carlos Martínez Toral [:carlosmartinez]]

Tested in unagi with 12/04/2012 nightly build: Gecko-0b1ed65 Gaia-23ce635

STR:
1-Open contacts app
2-Create a new contact with name, surname and phone number (e.g. 666666666666666666)
3-Tap in done button

Expected result --> New contact is saved with the values filled.
Actual result --> Done button is marked as inactive but nothing happens.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

I/Gecko   (  109): -*- ContactDB component: InternationalFormat: null
E/GeckoConsole(  109): [JavaScript Error: "this.internationalFormat is null" {file: "resource://gre/modules/PhoneNumber.jsm" line: 197}]

This is what I see in logcat. Gregor can you make sure this does not happens with the embedded version of libPhoneNumber?

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Gregor Wagner [:gwagner]]

Comment on attachment 688288 [details] [diff] [review]
patch

I still have to test it and I will make sure this gets merged to the github repo for phonenumberJS once it's landed.

Comment 4

[Gregor Wagner [:gwagner]]

Tested it and I can save now the number 666666666666666666.

Comment 5

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 6

[Andreas Gal :gal]

Comment on attachment 688288 [details] [diff] [review]
patch

Update the upstream repo too please. And alignment is off. : under the ? or ? under the first this and : under that ?.

Comment 7

[Andreas Gal :gal]

Comment on attachment 688297 [details] [diff] [review]
patch

Thanks.

Comment 8

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21689a2577de
https://hg.mozilla.org/integration/mozilla-inbound/rev/5941ffc63b8c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/21689a2577de
https://hg.mozilla.org/mozilla-central/rev/5941ffc63b8c

Comment 11

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/releases/mozilla-beta/rev/931ccf2e6da8
https://hg.mozilla.org/releases/mozilla-beta/rev/d902c67d2362

https://hg.mozilla.org/releases/mozilla-aurora/rev/e6c8ca7e009e
https://hg.mozilla.org/releases/mozilla-aurora/rev/cc2d5a097c01

Comment 12

[Natalya Kot [:nkot]]

Unagi Buid ID:20130103070201 - no repro, verified