[CONTACTS] Is not possible to save a contact with a very long phone number

VERIFIED FIXED

Status

Firefox OS
Gaia::Contacts
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: carlosmartinez, Assigned: gwagner)

Tracking

unspecified
x86_64
Windows 7
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed)

Details

Attachments

(2 attachments)

Tested in unagi with 12/04/2012 nightly build: Gecko-0b1ed65 Gaia-23ce635

STR:
1-Open contacts app
2-Create a new contact with name, surname and phone number (e.g. 666666666666666666)
3-Tap in done button

Expected result --> New contact is saved with the values filled.
Actual result --> Done button is marked as inactive but nothing happens.
blocking-basecamp: --- → ?
I/Gecko   (  109): -*- ContactDB component: InternationalFormat: null
E/GeckoConsole(  109): [JavaScript Error: "this.internationalFormat is null" {file: "resource://gre/modules/PhoneNumber.jsm" line: 197}]

This is what I see in logcat. Gregor can you make sure this does not happens with the embedded version of libPhoneNumber?
(Assignee)

Updated

6 years ago
Assignee: nobody → anygregor
(Assignee)

Comment 3

6 years ago
Comment on attachment 688288 [details] [diff] [review]
patch

I still have to test it and I will make sure this gets merged to the github repo for phonenumberJS once it's landed.
Attachment #688288 - Flags: review?(gal)
(Assignee)

Comment 4

6 years ago
Tested it and I can save now the number 666666666666666666.
(Assignee)

Comment 5

6 years ago
Created attachment 688297 [details] [diff] [review]
patch
Attachment #688297 - Flags: review?(gal)

Comment 6

6 years ago
Comment on attachment 688288 [details] [diff] [review]
patch

Update the upstream repo too please. And alignment is off. : under the ? or ? under the first this and : under that ?.
Attachment #688288 - Flags: review?(gal) → review+

Comment 7

6 years ago
Comment on attachment 688297 [details] [diff] [review]
patch

Thanks.
Attachment #688297 - Flags: review?(gal) → review+
https://hg.mozilla.org/mozilla-central/rev/21689a2577de
https://hg.mozilla.org/mozilla-central/rev/5941ffc63b8c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Duplicate of this bug: 819297

Comment 12

6 years ago
Unagi Buid ID:20130103070201 - no repro, verified
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.