817999 - remove DownloadMonitorPanel remnants

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I suppose this is a remaining part of the downloads in status bar thing, with the new downlods indicator this unmaintained code is likely pointless.
also the #download-monitor styling.

Gavin, is there a reason this was not removed? does it support some add-on or whatever else? It just looks like dead code to me, the only add-on using it looks like FireTorrent

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

http://mxr.mozilla.org/mozilla-central/search?string=DownloadMonitorPanel
http://mxr.mozilla.org/mozilla-central/search?string=%23download-monitor&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
https://mxr.mozilla.org/addons/search?string=DownloadMonitorPanel&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=addons

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Huh, I wasn't aware of the history here. Apparently bug 574688 removed the feature implemented in bug 402278, but only partially? Wonderful!

I don't see any reason to keep this code. http://hg.mozilla.org/mozilla-central/rev/d1ac428674f2 shows that you already identified all of the unused pieces, I think.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

sounds like a relaxing bug to take.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.0

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 688719 [details] [diff] [review]
patch v1.0

>-    this._activeStr = gNavigatorBundle.getString("activeDownloads1");
>-    this._pausedStr = gNavigatorBundle.getString("pausedDownloads1");

These strings are now unused.

>--- a/browser/themes/pinstripe/browser.css
>+++ b/browser/themes/pinstripe/browser.css
>@@ -3125,20 +3125,16 @@ toolbarbutton.chevron > .toolbarbutton-m
> #identity-popup-more-info-button:focus {
>   @hudButtonFocused@
> }
> 
> #identity-popup-more-info-button:hover:active {
>   @hudButtonPressed@
> }
> 
>-#download-monitor {
>-  list-style-image: url("chrome://mozapps/skin/downloads/downloadStatusIcon.png");
>-}

This image is now unused.

This patch makes gDownloadMgr unused as well.

Comment 6

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

ah good, I thought I searched for gDownloadMgr, probably search failed :/

looks like the string have been added in another push:
http://hg.mozilla.org/mozilla-central/rev/e1214959aead
So this is other stuff to check

I couldn't find the original push for the image, looks like has been addes with the new pinstripe in 2008

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

and also
http://hg.mozilla.org/mozilla-central/rev/b320791e4dde

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1.1

sorry for the incomplete patch on first try!

Comment 9

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33292b24d5d2

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/33292b24d5d2