Closed
Bug 818045
Opened 12 years ago
Closed 12 years ago
Make 'rebuild' button tooltip more clear
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(2 files)
5.32 KB,
patch
|
mbrubeck
:
review+
|
Details | Diff | Splinter Review |
2.22 KB,
patch
|
RyanVM
:
review+
|
Details | Diff | Splinter Review |
From email: Me... > Were the intermittent failures due to mis-compilation (and thus needed new builds each time)? > > If not, you can get retriggers of tests on the same run without having to push several > times (also saves the build time), by using the blue "+" button in the middle of the > lower TBPL UI panel. These work for anyone with an LDAP login. Other person: > thank you for the info. I didn't know about that feature. It is a bit > hidden and the popup hint is confusing since it says "rebuild" instead > of "rerun" or "retest". Other than a TBPL help video/tutorial (which is a good idea, but out of scope for now), I think all we can do here is s/Rebuild/Retrigger job/ or similar.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #688812 -
Flags: review?(mbrubeck)
Updated•12 years ago
|
Attachment #688812 -
Flags: review?(mbrubeck) → review+
Assignee | ||
Comment 2•12 years ago
|
||
Thank you :-) https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/1876364fdd96
Assignee | ||
Comment 3•12 years ago
|
||
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•12 years ago
|
||
Oops, this broke the buttons, due to the use of 'type' not only for title, but also in:
> onclick="UserInterface._' + type.toLowerCase()
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•12 years ago
|
||
I'm not a huge fan of the makeButton function, I don't think it gains us much - particularly if we want to use a more friendly button tooltip, and so would need to add another parameter for title too. This is also much more readable IMO. Ryan, asking you for review to start building up your familiarity with TBPL :-)
Attachment #692104 -
Flags: review?(ryanvm)
Updated•12 years ago
|
Attachment #692104 -
Flags: review?(ryanvm) → review+
Assignee | ||
Comment 6•12 years ago
|
||
Thank you :-) https://hg.mozilla.org/webtools/tbpl/rev/59909a7add37
Assignee | ||
Comment 7•12 years ago
|
||
Followup is in production.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Updated•10 years ago
|
Product: Webtools → Tree Management
Updated•9 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•