Closed Bug 818045 Opened 8 years ago Closed 8 years ago

Make 'rebuild' button tooltip more clear

Categories

(Tree Management Graveyard :: TBPL, defect)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(2 files)

From email:

Me...
> Were the intermittent failures due to mis-compilation (and thus needed new builds each time)?
>
> If not, you can get retriggers of tests on the same run without having to push several 
> times (also saves the build time), by using the blue "+" button in the middle of the 
> lower TBPL UI panel. These work for anyone with an LDAP login.

Other person:
> thank you for the info. I didn't know about that feature. It is a bit
> hidden and the popup hint is confusing since it says "rebuild" instead
> of "rerun" or "retest".

Other than a TBPL help video/tutorial (which is a good idea, but out of scope for now), I think all we can do here is s/Rebuild/Retrigger job/ or similar.
Attached patch Patch v1Splinter Review
Attachment #688812 - Flags: review?(mbrubeck)
Attachment #688812 - Flags: review?(mbrubeck) → review+
Depends on: 821491
In production :-)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Oops, this broke the buttons, due to the use of 'type' not only for title, but also in:
> onclick="UserInterface._' + type.toLowerCase()
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch FollowupSplinter Review
I'm not a huge fan of the makeButton function, I don't think it gains us much - particularly if we want to use a more friendly button tooltip, and so would need to add another parameter for title too. This is also much more readable IMO.

Ryan, asking you for review to start building up your familiarity with TBPL :-)
Attachment #692104 - Flags: review?(ryanvm)
Attachment #692104 - Flags: review?(ryanvm) → review+
Depends on: 821562
Followup is in production.
Status: REOPENED → RESOLVED
Closed: 8 years ago8 years ago
Resolution: --- → FIXED
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.