818045 - Make 'rebuild' button tooltip more clear

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

From email:

Me...
> Were the intermittent failures due to mis-compilation (and thus needed new builds each time)?
>
> If not, you can get retriggers of tests on the same run without having to push several 
> times (also saves the build time), by using the blue "+" button in the middle of the 
> lower TBPL UI panel. These work for anyone with an LDAP login.

Other person:
> thank you for the info. I didn't know about that feature. It is a bit
> hidden and the popup hint is confusing since it says "rebuild" instead
> of "rerun" or "retest".

Other than a TBPL help video/tutorial (which is a good idea, but out of scope for now), I think all we can do here is s/Rebuild/Retrigger job/ or similar.

Comment 1

[Ed Morley [:emorley]]

Attachment: Patch v1

Comment 2

[Ed Morley [:emorley]]

Thank you :-)

https://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/1876364fdd96

Comment 3

[Ed Morley [:emorley]]

In production :-)

Comment 4

[Ed Morley [:emorley]]

Oops, this broke the buttons, due to the use of 'type' not only for title, but also in:
> onclick="UserInterface._' + type.toLowerCase()

Comment 5

[Ed Morley [:emorley]]

Attachment: Followup

I'm not a huge fan of the makeButton function, I don't think it gains us much - particularly if we want to use a more friendly button tooltip, and so would need to add another parameter for title too. This is also much more readable IMO.

Ryan, asking you for review to start building up your familiarity with TBPL :-)

Comment 6

[Ed Morley [:emorley]]

Thank you :-)

https://hg.mozilla.org/webtools/tbpl/rev/59909a7add37

Comment 7

[Ed Morley [:emorley]]

Followup is in production.