Note: There are a few cases of duplicates in user autocompletion which are being worked on.

$CC is not used properly when not cross-compiling

RESOLVED FIXED in mozilla20

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla20
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
See our universal build mozconfig, for instance, which defines this:
  CC="$CC -arch $TARGET_CPU"
  CXX="$CXX -arch $TARGET_CPU"

But when building without cross-compilation, here's what we do in build/autoconf/compiler-opts.m4:
  MOZ_PATH_PROGS(CC, $CC clang)

Essentially, this doesn't do what one might expect, and the result is the build happens with /usr/bin/clang instead. Which is not a huge problem in the clang -arch x86_64 case because running clang alone does the same, but it is a problem when you try to set CC to something else. Also, it doesn't match what we do on other platforms.
(Assignee)

Comment 1

5 years ago
Created attachment 688290 [details] [diff] [review]
Properly use CC/CXX from mozconfig on non-cross-compile Mac builds
Attachment #688290 - Flags: review?(ted)
Comment on attachment 688290 [details] [diff] [review]
Properly use CC/CXX from mozconfig on non-cross-compile Mac builds

Review of attachment 688290 [details] [diff] [review]:
-----------------------------------------------------------------

This should obviate the need for the patch in bug 818061, right?
Attachment #688290 - Flags: review?(ted) → review+
(Assignee)

Comment 3

5 years ago
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> This should obviate the need for the patch in bug 818061, right?

Most likely yes.
No, I'm wrong, because without that other patch if you try to use the universal mozconfig locally you'll still wind up with things like CC=" -arch i386".
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/mozilla-central/rev/008f2249f16d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.