818131 - Volume Manager should create fake volumes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Dave Hylands [:dhylands]]

For devices which have no sdcard partition (like the Nexus S), apps like gallery don't work properly.

Since there is no sdcard partition, there is no sdcard volume, but /sdcard still exists (this implies that UMS won't work - but that's what MTP is for).

So I think that DeviceStorage GetSDCardStatus function should just assume that the sdcard is "available" if there is no sdcard volume.

Comment 1

[Dave Hylands [:dhylands]]

I actually have a workaround for this.

I'm planning on making nsIVolumeService.getVolumeByPath create a dummy volume if the path exists. This will allow DeviceStorage to query its size.

This particular solution will also be needed for work I'm doing with updates as well (bug 785124)

Noming since this blocks a blocker.

Comment 2

[Anil Sasidharan]

Attachment: Fix for sdcard detection on Pandaboard to solve the error from music, gallery and video apps

Patches vold to check if sdcard volume is mounted using FUSE file system. If mounted, volume-list is updated and upper layer can see the volume in response to "list volume" command.

Comment 3

[Dave Hylands [:dhylands]]

I've changed the description since the problem isn't in device storage.

Comment 4

[Dave Hylands [:dhylands]]

Comment on attachment 688673 [details] [diff] [review]
Fix for sdcard detection on Pandaboard to solve the error from music, gallery and video apps

Review of attachment 688673 [details] [diff] [review]:
-----------------------------------------------------------------

I've minused this for a few reasons:
1 - It changes vold, which is not something we control (i.e. if you want to change vold you need to get this into the upstream trees)
2 - Even if we could change vold, this doesn't address the problem properly. The FUSE mounted volumes still can't be shared via UMS, and the AutoMounter will try to UMS share the volumes reported by vold.
3 - I'll post my patch for this later today which should address the problem in a more suitable manner (and which will allow DeviceStorage and the Updater to work better as well)

Comment 5

[Dave Hylands [:dhylands]]

Attachment: Have GetVolumeByPath create a fake volume, if needed

This causes the GetVolumeByPath function to return a "fake" volume.

For volumes which don't exist in vold (like sdcard which is not a partition, or /data/local) this will allow VolumeService users like DeviceStorage and Updater to query the amount of space available/used on the partitions used to store the path in question.

This is, in fact, the only useful operation that can be performed with volumes anyway.

This, in turn, should allow the media based apps (Gallery, Music, Camera) to work again.

Comment 6

[Damon Sicore (:damons)]

Can we get a priority and target milestone for this>

Comment 7

[Doug Turner (:dougt)]

done.

Comment 8

[Damon Sicore (:damons)]

Let's get this checked in ASAP, please.  Sorry to press, but need to be acting as quickly as possible as we are in the endgame to reach 1/15. :)

Comment 9

[Dave Hylands [:dhylands]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a6a1c0d8a67

Comment 10

[Damon Sicore (:damons)]

Thanks, Dave.  :)

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1a6a1c0d8a67

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b3166db05250
https://hg.mozilla.org/releases/mozilla-beta/rev/04cbc663c774