818152 - dmADB uses subprocess.check_output() which is new in 2.7

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Andrew Halberstadt [:ahal]]

For some reason we are hitting an "zip/unzip failure: falling back to normal push" when using busybox on the test slaves. This doesn't actually cause a failure, but it adds 20-30 minutes of setup time to each job (since all the tests need to be pushed one at a time).

https://tbpl.mozilla.org/php/getParsedLog.php?id=17595016&tree=Cedar&full=1

Comment 1

[Andrew Halberstadt [:ahal]]

I pushed a patch to Cedar to add some debugging to devicemanager and we hit this traceback:
17:45:02     INFO -  Traceback (most recent call last):
17:45:02     INFO -    File "/home/cltbld/talos-slave/test/build/venv/lib/python2.6/site-packages/mozdevice/devicemanagerADB.py", line 206, in pushDir
17:45:02     INFO -      subprocess.check_output(["zip", "-r", localZip, '.'], cwd=localDir)
17:45:02     INFO -  AttributeError: 'module' object has no attribute 'check_output'

The check_output function is new as of python 2.7, patch coming shortly

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - uses Popen instead

Comment 3

[William Lachance (:wlach)]

Comment on attachment 688775 [details] [diff] [review]
Patch 1.0 - uses Popen instead

LGTM

Comment 4

[Andrew Halberstadt [:ahal]]

https://github.com/mozilla/mozbase/commit/a8cdc14cdbee1781cb811b57d48b6065cf76cc2e

Comment 5

[Andrew Halberstadt [:ahal]]

Because mozdevice on beta is so far behind trunk (and there are tons of api changes) I can't easily sync it. Unfortunately this means I need to cherry pick this change back to beta.

Comment 6

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/releases/mozilla-beta/rev/feff35567e4a