818158 - mozContact.find() - contains lookup on the "tel" field failing

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect, P2)

Description

[Etienne Segonzac (:etienne)]

A "contains" find with 699056123 will not match a contact with a 0699056123 phone number. Which is weird, since 0699056123 *does* contain 699056123.

But a "contains" find of [phone] will match 0699056123, so I guess we're doing something smart on the platform side which might be a bit too smart.

In the meantime all the contacts lookup from the Dialer are failing...

Comment 1

[Andrew Overholt [:overholt]]

We definitely need to fix this.  Is it related to PhoneNumberJS?

Comment 2

[Alex Keybl [:akeybl]]

Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.

Comment 3

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 4

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 689422 [details] [diff] [review]
patch

Review of attachment 689422 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/contacts/fallback/ContactDB.jsm
@@ +260,5 @@
>                  if (digits && number.length != digits.length) {
>                    digits = digits.join('');
>                    for(let i = 0; i < digits.length; i++) {
> +                    let num = digits.substring(i, digits.length);
> +                    if (contact.search[field].indexOf(num) < 0) {

Instead of doing this n^2 stuff let's just add all the numbers to a jsobj and then enumerate it at the end?

@@ +445,5 @@
>          let tmp = typeof options.filterValue == "string"
>                    ? options.filterValue.toLowerCase()
>                    : options.filterValue.toString().toLowerCase();
> +        if (key === 'tel') {
> +          let digits = options.filterValue.match(/\d/g);

Shouldn't this be 'tmp.match(...)'?

Comment 6

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf86988e2420

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bf86988e2420

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5e01b3def6e0
https://hg.mozilla.org/releases/mozilla-beta/rev/d14cad5e390a