818189 - GCLI: commands never receive the 'environment'

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mark Macdonald]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:18.0) Gecko/20100101 Firefox/18.0
Build ID: 20121128060531

Steps to reproduce:

1. Set up GCLI similar to this:
> gcli.createDisplay({
>     environment: { foo: 42 }
> });
> gcli.addCommand({
>     name: 'test',
>     exec: function(args, context) {
>         console.log('foo is: ' + context.environment.foo);
>     }
> });

2. Run the 'test' command and inspect its output.



Actual results:

Output is
> foo is: undefined



Expected results:

Output should have been
> foo is: 42

Comment 1

[Mark Macdonald]

Attachment: Proposed patch

Here is a patch that fixes the problem. The cause was a misspelling of the 'environment' field in display.js.

Comment 2

[Joe Walker [:jwalker]]

Thanks Mark.

This sounds silly, please could you tweak the patch to include a sign-off?
For details see: https://github.com/joewalker/gcli/blob/master/docs/developing-gcli.md

The short version is that the comment in the patch should include a line that says something like:
  Signed-off-by: Random J Developer <[e-mail]>

The beneficiary of this, bizarrely is IBM, particularly IBM's lawyers who like to know where stuff comes from.

Thanks.

Comment 3

[Mark Macdonald]

Attachment: Previous patch with sign-off added

Updated the patch to include a signoff.

Comment 4

[Joe Walker [:jwalker]]

Thanks Mark. Merged into GCLI.