Fix some warnings in Assembler-arm.cpp

RESOLVED FIXED in Firefox 20

Status

()

Core
JavaScript Engine
P4
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
mozilla20
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox19 wontfix, firefox20 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 688428 [details] [diff] [review]
part-1-fix-NULL-warnings.patch

When compiling for Android, I see the following compiler warnings about comparing n integer (uintptr_t) with a pointer (NULL):

js/src/ion/arm/Assembler-arm.cpp: In member function 'void js::ion::AutoFlushCache::update(uintptr_t, size_t)':
js/src/ion/arm/Assembler-arm.cpp:2445: warning: NULL used in arithmetic

js/src/ion/arm/Assembler-arm.cpp: In member function 'void js::ion::AutoFlushCache::flushAnyway()':
js/src/ion/arm/Assembler-arm.cpp:2487: warning: NULL used in arithmetic
Attachment #688428 - Flags: review?(dvander)
Attachment #688428 - Flags: review?(dvander) → review+
(Assignee)

Comment 1

5 years ago
Created attachment 688431 [details] [diff] [review]
part-2-make-functions-static.patch

Part 2: Also mark some Assembler-arm.cpp functions as static because they are only used within that source file.
Attachment #688431 - Flags: review?(dvander)
Comment on attachment 688431 [details] [diff] [review]
part-2-make-functions-static.patch

Review of attachment 688431 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/Assembler-arm.cpp
@@ +2320,1 @@
>  bool instIsGuard(Instruction *inst, const PoolHeader **ph)

nit, SpiderMonkey style is:

static bool
instIsGuard(...


r=me if you also want to fix the capitalization (InstIsGuard, InstIsBNop, InstIsArtificialGuard)
Attachment #688431 - Flags: review?(dvander) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9534e375800e
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b2656c880e8
Severity: normal → minor
status-firefox19: --- → wontfix
status-firefox20: --- → fixed
Target Milestone: --- → mozilla20

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/9534e375800e
https://hg.mozilla.org/mozilla-central/rev/9b2656c880e8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.