818245 - Fix some warnings in Assembler-arm.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P4)

Description

[Chris Peterson [:cpeterson]]

Attachment: part-1-fix-NULL-warnings.patch

When compiling for Android, I see the following compiler warnings about comparing n integer (uintptr_t) with a pointer (NULL):

js/src/ion/arm/Assembler-arm.cpp: In member function 'void js::ion::AutoFlushCache::update(uintptr_t, size_t)':
js/src/ion/arm/Assembler-arm.cpp:2445: warning: NULL used in arithmetic

js/src/ion/arm/Assembler-arm.cpp: In member function 'void js::ion::AutoFlushCache::flushAnyway()':
js/src/ion/arm/Assembler-arm.cpp:2487: warning: NULL used in arithmetic

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: part-2-make-functions-static.patch

Part 2: Also mark some Assembler-arm.cpp functions as static because they are only used within that source file.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 688431 [details] [diff] [review]
part-2-make-functions-static.patch

Review of attachment 688431 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/Assembler-arm.cpp
@@ +2320,1 @@
>  bool instIsGuard(Instruction *inst, const PoolHeader **ph)

nit, SpiderMonkey style is:

static bool
instIsGuard(...


r=me if you also want to fix the capitalization (InstIsGuard, InstIsBNop, InstIsArtificialGuard)

Comment 3

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9534e375800e
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b2656c880e8

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9534e375800e
https://hg.mozilla.org/mozilla-central/rev/9b2656c880e8