Closed
Bug 818258
Opened 13 years ago
Closed 13 years ago
Update the 'headerFile' descriptor field in Bindings.conf to reflect the latest changes in WeGLContext.h
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: sawrubh, Assigned: sawrubh)
References
()
Details
Attachments
(1 file)
|
2.57 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
With the recent changes of moving the various classes in WebGLContext.h out of that file and into separate headers, we need to update Bindings.conf to reflect this.
|
Assignee | |
Comment 1•13 years ago
|
||
Assignee: nobody → saurabhanandiit
Status: NEW → ASSIGNED
Attachment #688915 -
Flags: review?(bjacob)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 688915 [details] [diff] [review]
Patch v1
Review of attachment 688915 [details] [diff] [review]:
-----------------------------------------------------------------
Note that the reason why this was still compiling is that WebGLContext.h currently #includes the other headers.
We want to fix this. The present bug is a blocker for that.
Do you want to file the follow-up bug to fix that (have WebGLContext.h not include all the other headers, maybe re-add some forward-declarations as needed?)
Attachment #688915 -
Flags: review?(bjacob) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•