818263 - Make EventTarget binding work reliably for nodes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

In particular, nsINode does not inherit from nsDOMEventTargetHelper.  It sort of works out right this second because they have identical vtable layouts for the parts that matter, but relying on that is chancy.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make the EventTarget binding work for nodes.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Peter, is the castability bit at all right?  Or do I need to also implement QueryInterface on EventTarget?

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 688480 [details] [diff] [review]
Make the EventTarget binding work for nodes.



> #undef DOMCI_CASTABLE_INTERFACE
> #define DOMCI_CASTABLE_INTERFACES(_extra)                                     \
> DOMCI_CASTABLE_INTERFACE(nsINode, nsINode, 0, _extra)                         \
> DOMCI_CASTABLE_NODECL_INTERFACE(mozilla::dom::Element,  mozilla::dom::Element,\
>                                 1, _extra)                                    \
>+/* If this is ever removed, the IID for EventTarget can to go away */         \
>+DOMCI_CASTABLE_NODECL_INTERFACE(mozilla::dom::EventTarget,                    \
>+                                mozilla::dom::EventTarget, 2, _extra)         \
'can to go'?


> 'EventTarget': [
> {
>-    'nativeType': 'nsDOMEventTargetHelper',
>     'hasInstanceInterface': 'nsIDOMEventTarget',
>+    'hasXPConnectImpls': True,
>     'concrete': False,
>-    'prefable': True,
> },
I'm not familiar with this stuff

Comment 4

[Boris Zbarsky [:bzbarsky]]

> 'can to go'?

Should be just "can go".  ;)  I'll fix.

> I'm not familiar with this stuff

Yeah, Peter can handle that end of it.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Try run looks ok.

Comment 6

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db4197606782

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/db4197606782