Closed Bug 818286 Opened 8 years ago Closed 8 years ago

[inspector] "changes may be lost" dialog stays around after reload

Categories

(DevTools :: Inspector, defect, P1)

Product:
DevTools
Component:
Inspector
Version:
13 Branch
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 20

People

(Reporter: dcamp, Assigned: Optimizer)

References

Details

Attachments

(1 file, 1 obsolete file)

real fix
1.29 KB, patch
paul
: review+
Details | Diff | Splinter Review 
1) Open the inspector
2) Change a style
3) Reload the page
4) You'll get a dialog asking if you're sure, choose "Leave Page".

The page reloads correctly, but the bar stays visible.
Blocks: 816946
Summary: "changes may be lost" dialog stays around after reload → [inspector] "changes may be lost" dialog stays around after reload
Priority: -- → P1
QA Contact: scrapmachines
Assignee: nobody → scrapmachines
QA Contact: scrapmachines
Attached patch fix (obsolete) — — Splinter Review 
No need to return anything from the button's callback. In fact, returning true makes the notification stay.
Attachment #695158 - Flags: review?(dcamp)
Attached patch real fix — — Splinter Review 
No need to return from the button's callback function. In fact, returning true makes the notification stay.
Attachment #695158 - Attachment is obsolete: true
Attachment #695158 - Flags: review?(dcamp)
Attachment #695159 - Flags: review?(dcamp)
Attachment #695159 - Flags: review?(paul)
trying out more reviewers, any one who is free, please review. :)
Attachment #695159 - Flags: review?(paul)
Attachment #695159 - Flags: review?(dcamp)
Attachment #695159 - Flags: review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/eb2f66be4cc4
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/eb2f66be4cc4
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.