[inspector] "changes may be lost" dialog stays around after reload

RESOLVED FIXED in Firefox 20

Status

Product:
DevTools
Component:
Inspector
Type:
defect
Importance:
P1
normal
Status:
RESOLVED FIXED
Opened:
7 years ago
Updated:
Last year

People

(Reporter: dcamp, Assigned: Optimizer)

Tracking

Version:
13 Branch
Target:
Firefox 20
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

real fix
1.29 KB, patch
paul
: review+
Details | Diff | Splinter Review 
1) Open the inspector
2) Change a style
3) Reload the page
4) You'll get a dialog asking if you're sure, choose "Leave Page".

The page reloads correctly, but the bar stays visible.
Blocks: 816946
Summary: "changes may be lost" dialog stays around after reload → [inspector] "changes may be lost" dialog stays around after reload
Priority: -- → P1
QA Contact: scrapmachines
Assignee: nobody → scrapmachines
QA Contact: scrapmachines
Posted patch fix (obsolete) — — Splinter Review 
No need to return anything from the button's callback. In fact, returning true makes the notification stay.
Attachment #695158 - Flags: review?(dcamp)
Posted patch real fix — — Splinter Review 
No need to return from the button's callback function. In fact, returning true makes the notification stay.
Attachment #695158 - Attachment is obsolete: true
Attachment #695158 - Flags: review?(dcamp)
Attachment #695159 - Flags: review?(dcamp)
Attachment #695159 - Flags: review?(paul)
trying out more reviewers, any one who is free, please review. :)
Attachment #695159 - Flags: review?(paul)
Attachment #695159 - Flags: review?(dcamp)
Attachment #695159 - Flags: review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/eb2f66be4cc4
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/eb2f66be4cc4
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.