Closed
Bug 818291
Opened 13 years ago
Closed 13 years ago
MediaDecoder::SetMediaSeekable should not be final
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
|
905 bytes,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
18:12.41 In file included from /media/storage/moz/src/content/media/dash/DASHDecoder.cpp:128:
18:12.41 /media/storage/moz/src/content/media/dash/DASHRepDecoder.h:99:8: error: declaration of 'SetMediaSeekable' overrides a 'final' function
18:12.42 void SetMediaSeekable(bool aSeekable);
18:12.42 ^
18:12.42 ../../../dist/include/MediaDecoder.h:507:16: note: overridden virtual function is here
18:12.42 virtual void SetMediaSeekable(bool aMediaSeekable) MOZ_FINAL MOZ_OVERRIDE;
18:12.42 ^
18:12.67 1 error generated.
18:12.68
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Updated•13 years ago
|
Attachment #688484 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•