Closed Bug 818295 Opened 12 years ago Closed 12 years ago

[inspector] "changes may be lost" notification should be on the browser, not the toolbox

Categories

(DevTools :: Inspector, defect, P2)

13 Branch
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 20

People

(Reporter: dcamp, Assigned: Optimizer)

References

Details

Attachments

(1 file, 1 obsolete file)

If the reload in the browser is being blocked by the "changes may be lost" notification, should the notification be off in a potentially-hidden devtools window?
Blocks: 816946
Summary: "changes may be lost" notification should be on the browser, not the toolbox → [inspector] "changes may be lost" notification should be on the browser, not the toolbox
Priority: -- → P2
QA Contact: scrapmachines
Assignee: nobody → scrapmachines
QA Contact: scrapmachines
Attached patch fix (obsolete) — Splinter Review
grab the gBrowser's notification box when available.
Attachment #695162 - Flags: review?(dcamp)
Comment on attachment 695162 [details] [diff] [review]
fix

trying out more reviewers, any one who is free, please review. :)
Attachment #695162 - Flags: review?(paul)
Comment on attachment 695162 [details] [diff] [review]
fix

r=me with s/if(this.tabTarget)/if(this.target.isLocalTab)/
Attachment #695162 - Flags: review?(paul)
Attachment #695162 - Flags: review?(dcamp)
Attachment #695162 - Flags: review+
Attached patch coment addressedSplinter Review
carryover r+ from Paul
Attachment #695162 - Attachment is obsolete: true
Attachment #696686 - Flags: review+
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/2123f21f977a
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2123f21f977a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: