818311 - Add an e-tag to the marketplace manifest

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect, P2)

Description

[Wil Clouser [:clouserw]]

As reported in bug 813765, the marketplace isn't sending an etag with the manifest at:

> https://marketplace.firefox.com/telefonica/manifest.webapp

We should add etags to the marketplace's manifest in the same way we add them to the manifests we host.  Rob did the manifest code so I'm assigning to him, but Potch did the offline stuff and can help determine when we need to change the etag.  Please work together and come up with an answer.  If anything isn't clear let me know. Thanks. :)

Comment 1

[Rob Hudson [:robhudson]]

I asked about this on IRC on Friday and it seemed like there was confusion on our part why the manifest.webapp needs an etag vs the appcache.

Adding an etag header to the appcache sounds like a good idea regardless and is a bit easier as it has an explicit build step and we can simply hash the value of the appcache.

We generate the manifest.webapp dynamically when the request is made. It isn't clear to me what we'd use to trigger a etag bump on the manifest itself yet.

Comment 2

[Rob Hudson [:robhudson]]

Added etag based on the hash of the manifest contents:

https://github.com/mozilla/zamboni/commit/fe8f914