818343 - [AccessFu] Introduce gesture quick navigation

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

It is nice that we do it with a keyboard. But we really need to support it on screen-only devices.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Introduce gesture quick navigation!

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 688551 [details] [diff] [review]
Introduce gesture quick navigation!

Feedback: Absolutely awesome and working reliably!

Suggestion:

>+pref("accessibility.accessfu.quicknav_modes", "Link,ListItem,Heading,FormElement");

Move 'ListItem' to the end, and also add 'Table'. These are the most common things people jump to I believe. If we want to, we can add a settings panel where people can configure this later, and offer all supported quick nav elements to toggle. But that's a nice-to-have. I believe these would be highly appreciated as a start.

Comment 3

[Marco Zehe (:MarcoZ)]

We may have to decrease the distance a swipe left and right with 3 fingers is considered a swipe. I notice that the left and right swipes with 3 fingers is often not recognized on the Galaxy Nexus. On the Nexus 7, it's no problem, but there, my fingers have more room to swipe.

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 688551 [details] [diff] [review]
Introduce gesture quick navigation!

Review of attachment 688551 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/AccessFu.jsm
@@ +442,5 @@
> +      case 'swipeleft3':
> +        this.moveCursor('movePrevious', this.quickNavMode.current, 'gesture');
> +        break;
> +      case 'swipedown3':
> +        this.quickNavMode.next();

cool. so here is our mode list... (instead of a dial)... WFM

@@ +635,5 @@
> +    },
> +
> +    updateModes: function updateModes(aPrefsBranch) {
> +      try {
> +        this.modes = aPrefsBranch.getCharPref('quicknav_modes').split(',');

mild nit: I think I'd call it this.navmodes.

::: dom/locales/en-US/chrome/accessibility/AccessFu.properties
@@ +116,5 @@
> +navigationMode =      navigating
> +
> +# Quick navigation modes
> +quicknav_Simple      = Default
> +quicknav_Anchor      = Anchors

How is this stuff used?

::: mobile/android/app/mobile.js
@@ +632,5 @@
>  pref("ui.scrolling.min_scrollable_distance", -1);
>  
>  // Enable accessibility mode if platform accessibility is enabled.
>  pref("accessibility.accessfu.activate", 2);
> +pref("accessibility.accessfu.quicknav_modes", "Link,ListItem,Heading,FormElement");

nit: see MarcoZ above.

Comment 5

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #4)
> Comment on attachment 688551 [details] [diff] [review]
> Introduce gesture quick navigation!
> 
> Review of attachment 688551 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/jsat/AccessFu.jsm
> @@ +442,5 @@
> > +      case 'swipeleft3':
> > +        this.moveCursor('movePrevious', this.quickNavMode.current, 'gesture');
> > +        break;
> > +      case 'swipedown3':
> > +        this.quickNavMode.next();
> 
> cool. so here is our mode list... (instead of a dial)... WFM
> 
> @@ +635,5 @@
> > +    },
> > +
> > +    updateModes: function updateModes(aPrefsBranch) {
> > +      try {
> > +        this.modes = aPrefsBranch.getCharPref('quicknav_modes').split(',');
> 
> mild nit: I think I'd call it this.navmodes.

It is a member of quickNavMode, so it would be quickNavMode.navmodes, isn't that a bit redundant?

> 
> ::: dom/locales/en-US/chrome/accessibility/AccessFu.properties
> @@ +116,5 @@
> > +navigationMode =      navigating
> > +
> > +# Quick navigation modes
> > +quicknav_Simple      = Default
> > +quicknav_Anchor      = Anchors
> 
> How is this stuff used?

It is spoken when the mode changes, and it is displayed front and center.

> 
> ::: mobile/android/app/mobile.js
> @@ +632,5 @@
> >  pref("ui.scrolling.min_scrollable_distance", -1);
> >  
> >  // Enable accessibility mode if platform accessibility is enabled.
> >  pref("accessibility.accessfu.activate", 2);
> > +pref("accessibility.accessfu.quicknav_modes", "Link,ListItem,Heading,FormElement");
> 
> nit: see MarcoZ above.

I'll fix that.

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 688551 [details] [diff] [review]
Introduce gesture quick navigation!

Review of attachment 688551 [details] [diff] [review]:
-----------------------------------------------------------------

ok r=me

Comment 7

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf46c86deb67

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bf46c86deb67

Comment 9

[Marco Zehe (:MarcoZ)]

Verified the added feature in 20.0a1 2012-12-12.