This preserves the fiction that the state is that of the root document, not of the individual documents, though that's obviously false. Patch coming up that does the state updates sync on docshell active state change but keeps firing the events async. This does mean there's a time when the state has changed but the event has not fired yet, but I don't think I really care...
Comment on attachment 688609 [details] [diff] [review] Don't fire visibility change events until we're done updating vsibility states in the entire docshell tree. So the patch about updating the visibility state from docshell, not so much about changing the firing of the events. This needs some test.
Attachment #688609 - Flags: review?(bugs) → review+
Whiteboard: [need review]
Target Milestone: --- → mozilla20
That said, per the current processing model in the spec (but not the test suite!) our behavior was correct before this change. Working on figuring out whether the bug is in the spec or in the tests.
(In reply to Boris Zbarsky (:bz) from comment #4) > That said, per the current processing model in the spec (but not the test > suite!) our behavior was correct before this change Fun
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
I went ahead and backed this out, since our old behavior matches the spec and I don't want to ship a gratuitous change. If the spec ever changes, I'll look at this again. https://hg.mozilla.org/integration/mozilla-inbound/rev/3f93a72920e0
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [leave open][spec test suite bogus]
(In reply to Boris Zbarsky (:bz) from comment #7) > I went ahead and backed this out, since our old behavior matches the spec > and I don't want to ship a gratuitous change. If the spec ever changes, > I'll look at this again. > > https://hg.mozilla.org/integration/mozilla-inbound/rev/3f93a72920e0 Merge of backout: https://hg.mozilla.org/mozilla-central/rev/3f93a72920e0
Per mail in mailing list, this was just a test bug. The spec, and our code, is correct.
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.