Closed
Bug 818418
Opened 12 years ago
Closed 12 years ago
--enable-profiling adds --strip-debug flag unconditionally
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.13 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
The --strip-debug flag is not supported by OSX's strip.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #688671 -
Flags: review?(ted)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #688672 -
Flags: review?(ted)
|
|
Assignee | |
Updated•12 years ago
|
Attachment #688671 -
Attachment is obsolete: true
Attachment #688671 -
Flags: review?(ted)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 688672 [details] [diff] [review]
Don't set STRIP_FLAGS=--strip-debug on Windows, Mac and OS2
Review of attachment 688672 [details] [diff] [review]:
-----------------------------------------------------------------
::: configure.in
@@ +1657,5 @@
> # For profiling builds keep the symbol information
> if test "$MOZ_PROFILING" -a -z "$STRIP_FLAGS"; then
> + case "$OS_TARGET" in
> + WINNT|OS2|Darwin) ;;
> + *)
Would it make more sense to have a whitelist instead of a blacklist here?
Attachment #688672 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Used a whilelist instead (checked they mentioned BSD manpages, turns out they are all sing GNU strip)
http://hg.mozilla.org/mozilla-central/rev/251478307d97
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•