818436 - [toolbox] We should not be able to dock a toolbox if the target is Remote or Win

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

We should not be able to dock a toolbox if the target is Remote or Win

Original issue:
https://github.com/joewalker/devtools-window/issues/274

Comment 1

[Girish Sharma [:Optimizer]]

Attachment: Do not build dock buttons.

Do not build dock buttons, and also prevent switching in case of remote or window hosts.

Do tell if tests are required. (Not sure how to do that though yet.)

Comment 2

[Girish Sharma [:Optimizer]]

Comment on attachment 692008 [details] [diff] [review]
Do not build dock buttons.

I think this needs a test. Cancelling review request for now. I will look into how to open a remote debugger and a Browser debugger to test this feature.

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 692008 [details] [diff] [review]
Do not build dock buttons.

Can you use isTab (you'll need to implement it in target.jsm)

Comment 4

[Paul Rouget [:paul]]

isLocalTab is better.

Comment 5

[Girish Sharma [:Optimizer]]

Attachment: using isLocalTab

Still looking into how to open remote toolbox for testing purposes. If tests are not required for such a small change, please proceed to review instead of feedback.

Comment 6

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/a72eedce6602

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/a72eedce6602