[toolbox] We should not be able to dock a toolbox if the target is Remote or Win

RESOLVED FIXED in Firefox 20

Status

defect
P2
normal
RESOLVED FIXED
7 years ago
Last year

People

(Reporter: miker, Assigned: Optimizer)

Tracking

unspecified
Firefox 20
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We should not be able to dock a toolbox if the target is Remote or Win

Original issue:
https://github.com/joewalker/devtools-window/issues/274

Updated

7 years ago
Priority: -- → P2

Updated

7 years ago
Assignee: nobody → scrapmachines
Assignee

Comment 1

7 years ago
Posted patch Do not build dock buttons. (obsolete) — Splinter Review
Do not build dock buttons, and also prevent switching in case of remote or window hosts.

Do tell if tests are required. (Not sure how to do that though yet.)
Attachment #692008 - Flags: review?(paul)
Assignee

Comment 2

7 years ago
Comment on attachment 692008 [details] [diff] [review]
Do not build dock buttons.

I think this needs a test. Cancelling review request for now. I will look into how to open a remote debugger and a Browser debugger to test this feature.
Attachment #692008 - Flags: review?(paul) → feedback?(paul)
Comment on attachment 692008 [details] [diff] [review]
Do not build dock buttons.

Can you use isTab (you'll need to implement it in target.jsm)
Attachment #692008 - Flags: feedback?(paul) → feedback-
isLocalTab is better.
Assignee

Comment 5

7 years ago
Still looking into how to open remote toolbox for testing purposes. If tests are not required for such a small change, please proceed to review instead of feedback.
Attachment #692008 - Attachment is obsolete: true
Attachment #692520 - Flags: feedback?(paul)
Assignee

Updated

7 years ago
Whiteboard: [has-patch]

Updated

7 years ago
Attachment #692520 - Flags: feedback?(paul) → review+

Updated

7 years ago
Whiteboard: [has-patch] → [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/a72eedce6602
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a72eedce6602
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 20

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.