Closed Bug 818447 Opened 7 years ago Closed 7 years ago
[toolbox] Make the "Web Developer" appmenu entry a combo button (Linux & Windows).
Like the "new tab" button.
Original Github issue: https://github.com/joewalker/devtools-window/issues/186
Do we want to remove the "Toggle Toolbox" entry after the "Web Developer" menu in app menu becomes a combo button ? As I think clicking on Web Developer would itself open the Toolbox.
I think we want. Let's see how it feels.
Made the appmenu Web Developer entry a combo box. But now we have no information of whether a toolbox is opened for that tab through app menu.
Made Web Developer entry a combo box in App menu. But now we have lost the way to know whether toolbox is opened for that tab via app menu.
Comment on attachment 692463 [details] [diff] [review] Combo button >- <menu id="appmenu_webDeveloper" >- label="&appMenuWebDeveloper.label;"> >+ <splitmenu id="appmenu_webDeveloper" >+ observes="devtoolsMenuBroadcaster_WebDeveloper" >+ label="&appMenuWebDeveloper.label;"> > <menupopup id="appmenu_webDeveloper_popup"> >- <menuitem id="appmenu_devToolbox" >- observes="devtoolsMenuBroadcaster_DevToolbox"/> >- <menuseparator id="appmenu_devtools_separator"/> > <menuitem id="appmenu_devToolbar" > observes="devtoolsMenuBroadcaster_DevToolbar"/> We want to keep this menuitem: the combo button is not obvious and can be missed. >+#ifndef XP_MACOSX >+ <broadcaster id="devtoolsMenuBroadcaster_WebDeveloper" >+ /> >+#endif I would not create a new <broadcaster>, and instead of observers=…, I'd use command="Tools:DevToolbox".
Attachment #692463 - Flags: review?(paul) → review-
You just made the patch so easy..
(In reply to Girish Sharma [:Optimizer] from comment #7) > You just made the patch so easy.. Yeah, I'm like that :D
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.