Closed Bug 818459 Opened 10 years ago Closed 10 years ago

Fix browser_bug816527.js

Categories

(Firefox :: Private Browsing, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 20

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file, 1 obsolete file)

This test is currently failing on Birch...
Attached patch Patch (v1) (obsolete) — Splinter Review
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #688734 - Flags: review?(josh)
Attachment #688734 - Flags: review?(josh) → review+
Summary: Remove the event handlers for browser_bug816527.js when each windows test is run → Fix browser_bug816527.js
Attached patch Patch (v1)Splinter Review
Actually this test is completely broken -- pretty embarrassing I did not catch this before...  The last runTest call should actually do a switch to tab successfully since the source and dest windows are both non-private.  I have absolutely no idea why this test passes locally when run standalone but the test failure was actually happening because we rightly caught a TabClose event on the last call and we totally did not expect that.  At least it shows that my fix in bug 816527 is more solid than my test.  :-)
Attachment #688734 - Attachment is obsolete: true
Attachment #688788 - Flags: review?(josh)
Attachment #688788 - Flags: review?(josh) → review+
https://hg.mozilla.org/mozilla-central/rev/dc706e0d5c1c
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Depends on: 824025
You need to log in before you can comment on or make changes to this bug.