818493 - Make sure that an idle panda either knows how to reboot or stop the idleizer feature (if that's what it is)

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

2012-12-04 12:16:23-0800 [Broker,client] Connected to buildbot-master29.build.scl1.mozilla.com:9201; slave is ready
2012-12-04 19:16:23-0800 [-] I feel very idle and was thinking of rebooting as soon as the buildmaster says it's OK
2012-12-04 19:16:23-0800 [-] Telling the master we want to shutdown after any running builds are finished
2012-12-04 19:16:23-0800 [Broker,client] Master does not support slave initiated shutdown.  Upgrade master to 0.8.3 or later to use this feature.2012-12-04 19:16:23-0800 [Broker,client] rebooting NOW, since the master won't talk to us
2012-12-04 19:16:23-0800 [Broker,client] Invoking platform-specific reboot command
2012-12-04 19:16:23-0800 [Broker,client] lost remote
2012-12-04 19:16:23-0800 [Broker,client] Lost connection to buildbot-master29.build.scl1.mozilla.com:9201
2012-12-04 19:16:23-0800 [Broker,client] Stopping factory <buildslave.bot.BotFactory instance at 0x268fe18>
2012-12-04 19:16:23-0800 [-] Main loop terminated.
2012-12-04 19:16:23-0800 [-] Server Shut Down.

Comment 1

[Justin Wood (:Callek)]

I thought of two potential fixes here:

Hacky:
  -- Make the .tac output skip the idleizer code if slavename.startswith("panda-") will fix this bug, but is a poor end-result solution.

Correct-But-More-Work/Risky:
  -- Add a new slavealloc field on "use idleizer", which includes SQL to add the field default (True) to all slaves, the slavealloc importer to allow a value for the field, and SQL to set all pandas to not use it.

I'm discussing with coop what solution I'll do to fix the B2G-Blocking nature of this, but we'll still strive for the "Correct" solution on a more-longterm-way.

Comment 2

[Justin Wood (:Callek)]

Attachment: [tools] v1

This is the abridged-but-hacky version.

While in here I noticed that there is the ability to manually set a new .tac template, but it doesn't seem like we use it anywhere yet, so makes me nervous to use it until we have time to test.

If this passes muster we should spin out a new bug to eliminate this hack for the better solution

Comment 3

[Armen [:armenzg]]

Comment on attachment 688808 [details] [diff] [review]
[tools] v1

Thanks Callek!

http://hg.mozilla.org/build/tools/rev/f7788ad0fa64