Closed Bug 818518 Opened 12 years ago Closed 12 years ago

Camera - error-reporting runnables will leak if NS_DispatchToMainThread() fails

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:-)

Status:
RESOLVED FIXED
Project Flags:
blocking-basecamp -

People

(Reporter: mikeh, Assigned: mikeh)

Details

There are a couple of places where constructs like this are used: + rv = NS_DispatchToMainThread(new CameraErrorResult(mOnErrorCb, NS_LITERAL_STRING("FAILURE"), mCameraControl->GetWindowId())); + NS_ENSURE_SUCCESS(rv, rv); In all cases, if NS_DispatchToMainThread() fails, the new CameraErrorResult object is not cleaned up. The fix is to stuff each new object into an nsRefPtr<CameraErrorResult> first.
blocking-basecamp: --- → ?
blocking-basecamp: ? → -
Fixed in bug 830116. http://hg.mozilla.org/mozilla-central/rev/58a45d848070
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 833797
No longer blocks: 833797
You need to log in before you can comment on or make changes to this bug.