818528 - BaselineCompiler: Fix Call IC's non-optimizing-recursion bug.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Kannan Vijayan [:djvj]]

Baseline's call IC's fallback stub performs the call manually before adding a stub for it.  For recursive call stacks, this gets into a situation where none of the recursive activations are able to use optimized stack because the optimized call stub is not added until after the first recursive call is complete.

This leads to high stack usage and a "InternalError: too much recursion" error.

Showing up in jit-tests/test/basic/testBug673068.js

Comment 1

[Kannan Vijayan [:djvj]]

Attachment: Fix.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 688847 [details] [diff] [review]
Fix.

Review of attachment 688847 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/BaselineIC.cpp
@@ -1111,5 @@
> -
> -    types::TypeScript::Monitor(cx, res);
> -
> -    // Attach new stub.
> -    if (stub->numOptimizedStubs() >= ICCall_Fallback::MAX_OPTIMIZED_STUBS) {

Nit: we should keep this "if" so that we don't forget to fix it.

Comment 3

[Kannan Vijayan [:djvj]]

Nits fixed, committed:
https://hg.mozilla.org/projects/ionmonkey/rev/377ca8a512c3