818543 - 'mach build' fails because of missing $topsrcdir

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

When executing 'mach build' I get the following failure displayed:

Error running mach:

    ['build']

The error occured in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.

You should consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

CalledProcessError: Command '[u'/Volumes/data/code/firefox/nightly/python/mozbuild/mozbuild/mozconfig_loader', u'/Volumes/data/code/firefox/nightly/.mozconfig']' returned non-zero exit status 1

  File "/Volumes/data/code/firefox/nightly/python/mozbuild/mozbuild/mach_commands.py", line 31, in build
    warnings_path = self._get_state_filename('warnings.json')
  File "/Volumes/data/code/firefox/nightly/python/mozbuild/mozbuild/base.py", line 107, in _get_state_filename
    path = self.statedir
  File "/Volumes/data/code/firefox/nightly/python/mozbuild/mozbuild/base.py", line 79, in statedir
    return os.path.join(self.topobjdir, '.mozbuild')
  File "/Volumes/data/code/firefox/nightly/python/mozbuild/mozbuild/base.py", line 50, in topobjdir
    if self.mozconfig['topobjdir'] is None:
  File "/Volumes/data/code/firefox/nightly/python/mozbuild/mozbuild/base.py", line 65, in mozconfig
    self._mozconfig = loader.read_mozconfig()
  File "/Volumes/data/code/firefox/nightly/python/mozbuild/mozbuild/mozconfig.py", line 176, in read_mozconfig
    cwd=self.topsrcdir, env=env)
  File "/usr/local/Cellar/python/2.7.3/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 544, in check_output
    raise CalledProcessError(retcode, cmd, output=output)

Running the failing command manually I can see:

/Users/henrik/.mozconfigs/debug: line 1: /build/macosx/mozconfig.common: No such file or directory

There is no $topsrcdir set. As Mike told on IRC that python/mozbuild/mozbuild/mozconfig_loader is not setting topsrcdir like mozconfig2client-mk and mozconfig2configure does.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Define topsrcdir, v1

Trivial patch. Can't believe I missed this.

Comment 2

[Gregory Szorc [:gps]]

https://hg.mozilla.org/mozilla-central/rev/acd6c8f05685