818549 - Replace test-gather-startup with a function

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=ee593e4f6f53

Comment 1

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: Old one was missing a 'this'

https://tbpl.mozilla.org/?tree=Try&rev=83e577adc339

Comment 2

[Vladan Djeric (:vladan)]

Comment on attachment 688837 [details] [diff] [review]
Old one was missing a 'this'

>diff --git a/toolkit/components/telemetry/TelemetryPing.js b/toolkit/components/telemetry/TelemetryPing.js
>index 444fc26..bc5755e 100644
>--- a/toolkit/components/telemetry/TelemetryPing.js
>+++ b/toolkit/components/telemetry/TelemetryPing.js
>@@ -953,6 +953,15 @@ TelemetryPing.prototype = {
>     this._addons = aAddOns;
>   },
> 
>+  gatherStartup: function gatherStartup() {
>+    var counters = processInfo.getCounters();

Use "let" instead of "var"

Comment 3

[Vladan Djeric (:vladan)]

Nit: Also, maybe change function name back to "gatherStartupInformation".. It's a bit more descriptive

Comment 4

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

(In reply to Vladan Djeric (:vladan) from comment #3)
> Nit: Also, maybe change function name back to "gatherStartupInformation"..
> It's a bit more descriptive

https://hg.mozilla.org/integration/mozilla-inbound/rev/390569a008e5

There was already a function called gatherStartupInformation. I can rename gatherStartupInformation and/or gatherStartup in a followup patch if you want.

Comment 5

[Vladan Djeric (:vladan)]

(In reply to Rafael Ávila de Espíndola (:espindola) from comment #4)
> There was already a function called gatherStartupInformation. I can rename
> gatherStartupInformation and/or gatherStartup in a followup patch if you
> want.

Let's change the existing "gatherStartupInformation" to "gatherStartupHistograms" and then move the "this._slowSQLStartup" line out of "gatherStartupHistograms" and have its callers do that.

It also looks like we might have a bug in the getPayload() method.. it never calls getCounters() !

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/390569a008e5