818565 - Replace test-ping with a function

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

Attachment: patch

This completes the removal of the abuses of nsIObeserver by TelemetryPing.

https://tbpl.mozilla.org/?tree=Try&rev=b98fcfbee3e8

Comment 1

[Vladan Djeric (:vladan)]

Comment on attachment 688843 [details] [diff] [review]
patch

>diff --git a/toolkit/components/telemetry/TelemetryPing.js b/toolkit/components/telemetry/TelemetryPing.js
>index bc5755e..7b5e0b1 100644
>--- a/toolkit/components/telemetry/TelemetryPing.js
>+++ b/toolkit/components/telemetry/TelemetryPing.js
>@@ -962,13 +962,27 @@ TelemetryPing.prototype = {
>+  idle: function idle(aTest, aServer) {

nit: Let's call this something else, like sendIdlePing

>+    else if (Telemetry.canSend) {
>+      this.send("idle-daily", aServer);
>+    }

nit: put the 2 braces on the same line as the "else if". We use two different styles in this file, but generally we use the suggested style in Telemetry code

Comment 2

[Rafael Ávila de Espíndola (:espindola) (not reading bugmail)]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/8df4ccd2fc0d

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8df4ccd2fc0d