Closed Bug 818565 Opened 10 years ago Closed 10 years ago

Replace test-ping with a function

Categories

(Toolkit :: Telemetry, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: espindola, Assigned: espindola)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This completes the removal of the abuses of nsIObeserver by TelemetryPing.

https://tbpl.mozilla.org/?tree=Try&rev=b98fcfbee3e8
Attachment #688843 - Flags: review?(vdjeric)
Comment on attachment 688843 [details] [diff] [review]
patch

>diff --git a/toolkit/components/telemetry/TelemetryPing.js b/toolkit/components/telemetry/TelemetryPing.js
>index bc5755e..7b5e0b1 100644
>--- a/toolkit/components/telemetry/TelemetryPing.js
>+++ b/toolkit/components/telemetry/TelemetryPing.js
>@@ -962,13 +962,27 @@ TelemetryPing.prototype = {
>+  idle: function idle(aTest, aServer) {

nit: Let's call this something else, like sendIdlePing

>+    else if (Telemetry.canSend) {
>+      this.send("idle-daily", aServer);
>+    }

nit: put the 2 braces on the same line as the "else if". We use two different styles in this file, but generally we use the suggested style in Telemetry code
Attachment #688843 - Flags: review?(vdjeric) → review+
https://hg.mozilla.org/mozilla-central/rev/8df4ccd2fc0d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.