818583 - Permissions Installer - states that a privileged app can access device-storage:apps via PROMPT_ACTION, but permissions matrix states it should be DENY_ACTION

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Jason Smith [:jsmith]]

The permissions installer states the following about device-storage:apps:

74                            "device-storage:apps": {
75                              app: DENY_ACTION,
76                              privileged: PROMPT_ACTION,
77                              certified: ALLOW_ACTION,
78                              access: ["read", "write", "create"]
79                            },

However, the permissions matrix says it should be DENY_ACTION for a privileged app.

Comment 1

[Jason Smith [:jsmith]]

Same comment as the others:

- If doc is wrong - minus and state to update doc
- If code is wrong, let's + and fix this

Comment 2

[Jason Smith [:jsmith]]

Spoke with Gregor in IRC - all of them going his way to resolve the contention.

Comment 3

[Lucas Adamski [:ladamski]]

I believe this permission allows access to the entire apps directory, right?  If so we should definitely fix the code to match the perms matrix.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

There are two changes needed here:

privileged should be DENY_ACTION and the access property should just be ["read"]

Comment 5

[Gregor Wagner [:gwagner]]

Attachment: pointer

Comment 6

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 7

[Gregor Wagner [:gwagner]]

https://github.com/mozilla-b2g/gaia/commit/69bbfcf06bfe6b8c19567f711ef84e2109b8f0f6

Comment 8

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef0d9ad6a17d

Comment 9

[Gregor Wagner [:gwagner]]

Fix tests:
https://hg.mozilla.org/integration/mozilla-inbound/rev/01654665475b

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/ef0d9ad6a17d
https://hg.mozilla.org/mozilla-central/rev/01654665475b

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/165fef5b307d
https://hg.mozilla.org/releases/mozilla-aurora/rev/332922a0d40c

https://hg.mozilla.org/releases/mozilla-beta/rev/f38ec49d0117
https://hg.mozilla.org/releases/mozilla-beta/rev/2415b272e69a