Closed Bug 818624 Opened 9 years ago Closed 7 years ago

Link to "about:credits" on Firefox OS

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S2 (15aug)

People

(Reporter: Margaret, Assigned: gasolin)

References

Details

(Keywords: uiwanted, Whiteboard: [p=1])

Attachments

(3 files)

It would be cool to feature all our contributors in a list somewhere that users can get to. On Firefox desktop, there is a link to about:credits in the about box, so maybe we can make a similar link in our "About Firefox OS" section.

Initially I was thinking we would make a new credits page for Firefox OS, but there would actually be a lot of overlap with about:credits, so maybe we should just use that. After all, Firefox OS was built on top of a lot of work that was already done by the Mozilla community that's credited in about:credits.
Following discussion on IRC, we should use about:credits. Updating the summary.
Summary: Link to an "about:credits" page for Firefox OS → Link to "about:credits" on Firefox OS
Please note that the about:credits page is already linked from inside the browser application, although I think should be more visible including some general information about Mozilla and how newcomers can get involved.
Depends on: 850874
Hi all:  Aakash had worked on this before he left.  I can't find the bug unfortunately and it was based off of Mozillians.

I believe it's already in play.
We may want to consider adding a link to 'about:credits' on the Device information screen in the Settings app, which I think is the Firefox OS equivalent to 'about:firefox' on desktop. The link could be added as a button in the About Firefox OS section of this screen.

(In reply to Tomer Cohen :tomer from comment #2)
> Please note that the about:credits page is already linked from inside the
> browser application, although I think should be more visible including some
> general information about Mozilla and how newcomers can get involved.

Great points Tomer. For reference, this link can be found on Firefox OS by:
- Opening Firefox
- Tap on the tab number to reveal the Settings icon
- Tap on the Settings icon
- Tap on About Firefox
- Tap on Credits

Note that the Credits page layout could be more responsive on a mobile screen so you don't need to scroll horizontally.

(In reply to Mary from comment #3)
> Hi all:  Aakash had worked on this before he left.  I can't find the bug
> unfortunately and it was based off of Mozillians.
> 
> I believe it's already in play.

Aakash was working on bug 782417, which includes a list of all vouched Mozillians as of September 2012. That bug has been inactive for a few months, and it doesn't appear to be resolved yet.
See Also: → 782417
I think it's an pretty interesting feature, jenny do you think it's reasonable on UI
Flags: needinfo?(jelee)
Flags: needinfo?(bhuang)
Thanks gary to point out the firefox browser contributor credit page https://www.mozilla.org/credits/

It's a good start. Though We'd need to find a way to also include gaia, ux, pm in another page...
according to https://www.mozilla.org/credits/faq/

TL;DR; we could link to https://www.mozilla.org/credits/ directly.

long:

This is a list of people who have "made a significant investment of time, with useful results, into Mozilla project-governed activities". Any such contributors who wish to be added to the list should fill in this form. There is a FAQ about this process. The list was last updated July 8, 2014.
We do have a About Firefox OS section at Settings> Device information. I'd assume this is the most reasonable place to put the info/link.
Flags: needinfo?(jelee)
I assume the place would be under `Legal Information` link.
The world might be `Credit`

@jenny could you kindly confirm or provide exact place and wording for the link? so we can turn it to an doable issue.
Flags: needinfo?(jelee)
Attached image screenshot.png
quick implement, use same link style as in `Legal Information`. 

Looks not well.../_\ any suggestion?
Assignee: nobody → gasolin
Hello Fred,

Supposedly the "credit" button should be a list button with chevron (the style of "your rights", "your privacy" & "legal information" is not entirely correct according to the latest building block guide, but we will fix this at 2.2 or after).

Are we committed to do this? If so, I'll create a spec for this ;)
Flags: needinfo?(jelee)
Big thanks jenny for help the bug sweeping :)


I'd try to address some community driven bugs and like this bug may need more UX decision.

This is not a committed or hurry feature though, if chevron style is fine I could mimic it :)
Attached image credit link
Hi jenny,

I've applied button style, is it looks ok?
Attachment #8468363 - Flags: ui-review?(jelee)
Current feedback on mail list looks pretty positive https://groups.google.com/forum/#!topic/mozilla.dev.gaia/4w3hB7Ebnbw
Comment on attachment 8468363 [details]
credit link

Looks good! What happens next when user tap on credit?
Attachment #8468363 - Flags: ui-review?(jelee) → ui-review+
Thanks for UI review!

When user tap on credit button, The browser will be opened and show the credit page.
Attachment #8469014 - Flags: review?(arthur.chen)
"Credits" would be proper English here.
Thanks kyle! updated.
Comment on attachment 8469014 [details] [review]
pull request redirect to github

Have discuss with @ej and redirect the review to him to offload Arthur's workload.
Attachment #8469014 - Flags: review?(arthur.chen) → review?(ejchen)
Comment on attachment 8469014 [details] [review]
pull request redirect to github

Thanks Fred, please rebase first and make sure CI is green before merging !
Attachment #8469014 - Flags: review?(ejchen) → review+
green and merged to gaia-master https://github.com/mozilla-b2g/gaia/commit/40a5e2589b7947543ca57f40393b0c9af5e5fd74

thanks!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Flags: needinfo?(bhuang)
Whiteboard: [p=1]
Target Milestone: --- → 2.1 S2 (15aug)
You need to log in before you can comment on or make changes to this bug.