818807 - Enable screenshot for everything.me / add-to-homescreen apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

When working on bug 808227, I mistakenly stop the unpainted flag from being set on the wrapper frame. This, and only rely on |frame.src| for look up screenshots in database, stopped screenshot from shown on the wrapper frame.

I have a patch that will fix this.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/6848

https://github.com/mozilla-b2g/gaia/pull/6848

[Approval Request Comment]
Bug caused by (feature/regressing bug #): minor regression cause by bug 808227
User impact if declined: wrapper frame will begin plain white
Testing completed: yes, on Otoro
Risk to taking this patch (and alternatives if risky): it's only a few lines of code and contained within window manager.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 689108 [details]
Github: https://github.com/mozilla-b2g/gaia/pull/6848

Note: The readability will be improved if you do some Github magic: https://github.com/mozilla-b2g/gaia/pull/6848/files?w=1

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/5803fa0e0e57b7297e9dd5f4e909a74240d72dbe

Thanks!