818824 - Fire an event when no audio channel is playing now

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

This is follow-up of bug 811222.
See http://people.mozilla.com/~lco/FFOS/Sound/R1_Sound%20Spec_v1%20DRAFT.pdf page.7

Bug 811222 will send an event in these cases to system app:
1. Content is starting to play.
2. Alarm is starting to play.
3. Notification is starting to play.

However we don't know when is
* Content stops playing.

The default channel by UX design is now notification channel. Either send notification or send default makes sense to me, but bug 810780 just couldn't live without knowing when is content stop playing.

I want to claify another thing: audio-channel-changed is relavant to channel type, not the settings they listen to coz the later could be changed in the future.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Hmm.. we might be missing a notification that is sent to gaia when *no* audio channel is used.

Note that the notifications from bug 811222 are intended to just notify gaia about which audio channel is currently the active audio channel. Gaia can and should then decide which volume to adjust according to the rules in the UI spec.

The platform should not send notifications which are UI specific. It should be up to gaia to make UI decisions.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

comment 1 seems to make sense given everything else we have implemented to date. Should we add "no" audio channel notification quickly in order to close out remaining feature bugs? thanks

Comment 3

[Andrew Overholt [:overholt]]

Jonas, should we add the notification in the audio manager?

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Jonas Sicking (:sicking) from comment #1)
> Hmm.. we might be missing a notification that is sent to gaia when *no*
> audio channel is used.
> 
> Note that the notifications from bug 811222 are intended to just notify gaia
> about which audio channel is currently the active audio channel. Gaia can
> and should then decide which volume to adjust according to the rules in the
> UI spec.
> 
> The platform should not send notifications which are UI specific. It should
> be up to gaia to make UI decisions.

That's what I mean in https://bugzilla.mozilla.org/show_bug.cgi?id=811222#c24 :)
And I also agree not to hardcode default=some-channel in platform.

Could somebody quickly pick this? This bug is the key to close bug 810780.

Comment 5

[Marco Chen [:mchen]]

Attachment: Notify Default v1

Comment 6

[Marco Chen [:mchen]]

Comment on attachment 689543 [details] [diff] [review]
Notify Default v1

Hi Jonas,

Due to that now is the sleeping time of Andrea's time zone, so set reviewer to you. If you doesn't have time for this, I will set it to Andrea. Thanks.

Comment 7

[Marco Chen [:mchen]]

Comment on attachment 689543 [details] [diff] [review]
Notify Default v1

Hi Andrea,

Thanks for your review in advance.

Comment 8

[Marco Chen [:mchen]]

Attachment: Patch Checkin-Version

Thanks Andrea.

Comment 9

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ea87412bc5b

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/1ea87412bc5b

Comment 11

[Andrew Overholt [:overholt]]

Andrea told me we wouldn't this to regress because without it we don't inform apps when the audio channel is "default".

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c6ab750adda7
https://hg.mozilla.org/releases/mozilla-beta/rev/4b84a1a1e534