Closed Bug 818824 Opened 10 years ago Closed 10 years ago

Fire an event when no audio channel is playing now

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-basecamp:+, firefox18 fixed, firefox19 fixed, firefox20 fixed, b2g18 fixed)

RESOLVED FIXED
B2G C2 (20nov-10dec)
blocking-basecamp +
Tracking Status
firefox18 --- fixed
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: alive, Assigned: mchen)

References

Details

Attachments

(1 file, 1 obsolete file)

This is follow-up of bug 811222.
See http://people.mozilla.com/~lco/FFOS/Sound/R1_Sound%20Spec_v1%20DRAFT.pdf page.7

Bug 811222 will send an event in these cases to system app:
1. Content is starting to play.
2. Alarm is starting to play.
3. Notification is starting to play.

However we don't know when is
* Content stops playing.

The default channel by UX design is now notification channel. Either send notification or send default makes sense to me, but bug 810780 just couldn't live without knowing when is content stop playing.

I want to claify another thing: audio-channel-changed is relavant to channel type, not the settings they listen to coz the later could be changed in the future.
Hmm.. we might be missing a notification that is sent to gaia when *no* audio channel is used.

Note that the notifications from bug 811222 are intended to just notify gaia about which audio channel is currently the active audio channel. Gaia can and should then decide which volume to adjust according to the rules in the UI spec.

The platform should not send notifications which are UI specific. It should be up to gaia to make UI decisions.
comment 1 seems to make sense given everything else we have implemented to date. Should we add "no" audio channel notification quickly in order to close out remaining feature bugs? thanks
Jonas, should we add the notification in the audio manager?
Flags: needinfo?(jonas)
(In reply to Jonas Sicking (:sicking) from comment #1)
> Hmm.. we might be missing a notification that is sent to gaia when *no*
> audio channel is used.
> 
> Note that the notifications from bug 811222 are intended to just notify gaia
> about which audio channel is currently the active audio channel. Gaia can
> and should then decide which volume to adjust according to the rules in the
> UI spec.
> 
> The platform should not send notifications which are UI specific. It should
> be up to gaia to make UI decisions.

That's what I mean in https://bugzilla.mozilla.org/show_bug.cgi?id=811222#c24 :)
And I also agree not to hardcode default=some-channel in platform.

Could somebody quickly pick this? This bug is the key to close bug 810780.
Summary: Change default audio channel to meet UX requirement → Fire an event when no audio channel is playing now
Attached patch Notify Default v1 (obsolete) — Splinter Review
Comment on attachment 689543 [details] [diff] [review]
Notify Default v1

Hi Jonas,

Due to that now is the sleeping time of Andrea's time zone, so set reviewer to you. If you doesn't have time for this, I will set it to Andrea. Thanks.
Attachment #689543 - Flags: review?(jonas)
Comment on attachment 689543 [details] [diff] [review]
Notify Default v1

Hi Andrea,

Thanks for your review in advance.
Attachment #689543 - Flags: review?(jonas) → review?(amarchesini)
Attachment #689543 - Flags: review?(amarchesini) → review+
Thanks Andrea.
Attachment #689543 - Attachment is obsolete: true
Attachment #689666 - Flags: review+
Assignee: nobody → mchen
https://hg.mozilla.org/mozilla-central/rev/1ea87412bc5b
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Andrea told me we wouldn't this to regress because without it we don't inform apps when the audio channel is "default".
blocking-basecamp: ? → +
Whiteboard: [status-b2g18:fixed]
Whiteboard: [status-b2g18:fixed]
You need to log in before you can comment on or make changes to this bug.