Closed Bug 819096 Opened 8 years ago Closed 8 years ago

Fix for =/== confusion in trickle ICE

Categories

(Core :: WebRTC: Networking, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: ekr, Assigned: ekr)

Details

(Whiteboard: [nICEr][WebRTC][blocking-webrtc+][qa-])

Attachments

(1 file, 2 obsolete files)

No description provided.
This also suppresses multiple registrations of the callbacks.
Attachment #689384 - Flags: review?(adam)
Attachment #689384 - Attachment is obsolete: true
Attachment #689384 - Flags: review?(adam)
Comment on attachment 689384 [details] [diff] [review]
Fix for =/== confusion in trickle ICE

Review of attachment 689384 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: media/mtransport/third_party/nICEr/src/ice/ice_component.c
@@ +610,3 @@
>  
> +      if (!was_paired) {
> +        /* Add the stun username/password pair from the last pair (any 

Trailing WS

@@ +618,2 @@
>             pair->r2l_user,&pair->r2l_pwd,nr_ice_component_stun_server_cb,pcomp))
> +             ABORT(r);

There are a number of coding style variations between this project and Mozilla's in general, and I would favor consistency over any attempt to mix them; but this one has maintainability implications:

The moz guidelines, like most style guides I'm familiar with, require bracing of all controlled statements, even if they're only one line. It's just too easy for a naive maintainer to trip across this code and Do The Wrong Thing.

@@ +633,5 @@
>        
>        pcand=TAILQ_NEXT(pcand,entry_comp);
>      }
>  
> +  done:

I don't think this label serves any purpose; it should probably be removed.
Attachment #689384 - Attachment is obsolete: false
Attachment #689384 - Flags: review+
Attachment #689384 - Attachment is obsolete: true
Attachment #689409 - Attachment is obsolete: true
Whiteboard: [nICEr]
Whiteboard: [nICEr] → [nICEr][WebRTC][blocking-webrtc+]
Attachment #689429 - Flags: review?(adam)
Comment on attachment 689429 [details] [diff] [review]
Fix for =/== confusion in trickle ICE

Review of attachment 689429 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #689429 - Flags: review?(adam) → review+
Attachment #689429 - Flags: checkin?(rjesup)
Attachment #689429 - Flags: checkin?(rjesup) → checkin+
https://hg.mozilla.org/mozilla-central/rev/6ab2a1b55394
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [nICEr][WebRTC][blocking-webrtc+] → [nICEr][WebRTC][blocking-webrtc+][qa-]
You need to log in before you can comment on or make changes to this bug.