819096 - Fix for =/== confusion in trickle ICE

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Comment 1

[Eric Rescorla (:ekr)]

Attachment: Fix for =/== confusion in trickle ICE

Comment 2

[Eric Rescorla (:ekr)]

This also suppresses multiple registrations of the callbacks.

Comment 3

[Eric Rescorla (:ekr)]

Attachment: Fix for =/== confusion in trickle ICE

Comment 4

[Adam Roach [:abr]]

Comment on attachment 689384 [details] [diff] [review]
Fix for =/== confusion in trickle ICE

Review of attachment 689384 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

::: media/mtransport/third_party/nICEr/src/ice/ice_component.c
@@ +610,3 @@
>  
> +      if (!was_paired) {
> +        /* Add the stun username/password pair from the last pair (any 

Trailing WS

@@ +618,2 @@
>             pair->r2l_user,&pair->r2l_pwd,nr_ice_component_stun_server_cb,pcomp))
> +             ABORT(r);

There are a number of coding style variations between this project and Mozilla's in general, and I would favor consistency over any attempt to mix them; but this one has maintainability implications:

The moz guidelines, like most style guides I'm familiar with, require bracing of all controlled statements, even if they're only one line. It's just too easy for a naive maintainer to trip across this code and Do The Wrong Thing.

@@ +633,5 @@
>        
>        pcand=TAILQ_NEXT(pcand,entry_comp);
>      }
>  
> +  done:

I don't think this label serves any purpose; it should probably be removed.

Comment 5

[Eric Rescorla (:ekr)]

Attachment: Fix for =/== confusion in trickle ICE

Comment 6

[Adam Roach [:abr]]

Comment on attachment 689429 [details] [diff] [review]
Fix for =/== confusion in trickle ICE

Review of attachment 689429 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6ab2a1b55394

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6ab2a1b55394

Comment 9

[Adam Roach [:abr]]

Landed on resiprocate trunk r9911: http://svn.resiprocate.org/viewsvn/resiprocate/main/nICEr/src/ice/ice_component.c?diff_format=l&r1=9911&r2=9910&pathrev=9911