Closed Bug 819158 Opened 11 years ago Closed 10 years ago

Implement stopAtOuter for UnwrapObjectChecked

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: bholley, Assigned: bholley)

References

Details

Attachments

(1 file)

Introduce stopAtOuter for UnwrapObjectChecked. v1
3.18 KB, patch
mrbkap
: review+
Details | Diff | Splinter Review 
It's starting to get annoying to JS_ObjectToInnerObject after every UnwrapObjectChecked. Let's align the semantics here with js::UnwrapObject.
Blocks: 658909
We need to simultaneously stop marking outers as unsafe to unwrap, otherwise
we'll end up with paradoxical behavior whereby stopAtOuter=true returns null
but stopAtOuter=false returns an object. This is fine, because we're now
handling outer explicitly.
Attachment #713498 - Flags: review?(mrbkap)
Attachment #713498 - Flags: review?(mrbkap) → review+
https://hg.mozilla.org/mozilla-central/rev/24c55c2834b1
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.