Closed Bug 819234 Opened 12 years ago Closed 11 years ago

B2G Multi-SIM: refactor audio control in RIL

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: hsinyi, Assigned: hsinyi)

References

Details

Attachments

(2 files, 1 obsolete file)

In multi-sim configuration, we will have MSimRadioInterfaceLayer as a manger of RadioInterfaceLayer instances. We should move audio phone state control to MSimRadioInterfaceLayer, instead of leaving it in each instance, because we only have one audio hardware. The audio control is applied globally.
Assignee: nobody → htsai
Attached patch WIP - rebased on bug 814581 (obsolete) — Splinter Review
Having a separate gCallAudioManager to handle call audio state
Move 'RIL:GetMicrophoneMuted,' 'RIL:GetMicrophoneMuted,' 'RIL:GetMicrophoneMuted,' and 'RIL:GetMicrophoneMuted' to |RadioInterfaceLayer.receiveMessage|
Attachment #764686 - Attachment is obsolete: true
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #3)
> Created attachment 765185 [details] [diff] [review]
> WIP - rebased on bug 814581 (v2)
> 
> Move 'RIL:GetMicrophoneMuted,' 'RIL:GetMicrophoneMuted,'
> 'RIL:GetMicrophoneMuted,' and 'RIL:GetMicrophoneMuted' to
> |RadioInterfaceLayer.receiveMessage|

Oops, wrong comment, should be moving to |MessageManager.receiveMessage|, instead of |RadioInterface.receiveMessage|
Component: DOM: Device Interfaces → RIL
Product: Core → Boot2Gecko
Discussed with Hsin-yi and closed it.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: