819242 - JAWS needs old IServiceProvider::QueryService

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

it's regression from bug 762770 where we corrected IServiceProvider::QueryInterface implementation. JAWS uses old behavior. Let's get back it in compatibility mode.

Comment 1

[Trevor Saunders (:tbsaunde)]

Comment on attachment 689576 [details] [diff] [review]
patch

in future I think I'd prefer this compatibility stuff had a max version we allow to use compatibility mode so we don't need to support it forever, and we can be sure newer versions are fixed.

Comment 2

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #1)

> in future I think I'd prefer this compatibility stuff had a max version we
> allow to use compatibility mode so we don't need to support it forever, and
> we can be sure newer versions are fixed.

agree, in practice it might be no smooth since we don't when they fix their bug.

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to alexander :surkov from comment #0)
> Created attachment 689576 [details] [diff] [review]
> patch
> 
> it's regression from bug 762770 where we corrected
> IServiceProvider::QueryInterface implementation. JAWS uses old behavior.
> Let's get back it in compatibility mode.

That's all the way back to FF 16 I think :(

How can we catch these faster?

Comment 4

[alexander :surkov (:asurkov)]

(In reply to David Bolter [:davidb] from comment #3)

> That's all the way back to FF 16 I think :(
> 
> How can we catch these faster?

I missed that when I blogged about FF 16. Tech news should be helpful. And of course we need MATS finished.

Comment 5

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f387a7a86f2f

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/f387a7a86f2f

Comment 7

[James Teh [:Jamie]]

Can you please clarify what changed that broke JAWS? I don't think we've broken in any way, but I want to make sure I haven't missed something.

Comment 8

[alexander :surkov (:asurkov)]

here's the change: https://hg.mozilla.org/mozilla-central/diff/4a898478fe06/accessible/src/msaa/nsAccessNodeWrap.cpp. So previously you could get, say, application accessible by passing any supported guid service and IApplicationAccessible as iid. Now you need to pass IApplicationAccessible uid as guid service.

(more info http://asurkov.blogspot.ru/2012/12/iserverprovider-implementation-in.html)

Comment 9

[alexander :surkov (:asurkov)]

Comment on attachment 689576 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 819242
User impact if declined: JAWS user experience is broken
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): no risk, getting things back that were prior to bug 819242, code is enabled under JAWS compatibility mode (non JAWS users aren't affected by the patch) 
String or UUID changes made by this patch: no

Comment 10

[Trevor Saunders (:tbsaunde)]

(In reply to alexander :surkov from comment #9)
> Comment on attachment 689576 [details] [diff] [review]
> patch
> 
> [Approval Request Comment]
> Bug caused by (feature/regressing bug #): bug 819242
> User impact if declined: JAWS user experience is broken
> Testing completed (on m-c, etc.): m-c
> Risk to taking this patch (and alternatives if risky): no risk, getting
> things back that were prior to bug 819242, code is enabled under JAWS
> compatibility mode (non JAWS users aren't affected by the patch) 
> String or UUID changes made by this patch: no

s/bug 819242/bug 762770/ right?

Comment 11

[alexander :surkov (:asurkov)]

Yes, thank you for the catch.

Comment 12

[Alex Keybl [:akeybl]]

Comment on attachment 689576 [details] [diff] [review]
patch

Returning to previous behavior, and it sounds like this is broken regardless.

Comment 13

[alexander :surkov (:asurkov)]

(In reply to Alex Keybl [:akeybl] from comment #12)
> Comment on attachment 689576 [details] [diff] [review]
> patch
> 
> Returning to previous behavior, and it sounds like this is broken regardless.

only as part of backward compatibility thing, eventually this will be removed when we stop the support of old JAWS versions.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/326604b96f96
https://hg.mozilla.org/releases/mozilla-beta/rev/2f0ec8fbaa36

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/2f0ec8fbaa36