819246 - Built failed when $target_arch is "arm" but not armv7

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[StevenLee[:slee]]

As comment 7 on bug 818843, we should 
1. set default value of "arm_neon" to 0, or
2. go through all gypi files and fix the logistic error. That is only when "armv7" is true then we check the value of "arm_neon"

Comment 1

[StevenLee[:slee]]

Attachment: patch

Hi ted,

Could you please review the patch or suggest someone to review it? I am not sure who is suitable to review the patch. I found that you are the reviewer of the file from log. 
Thanks.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 689593 [details] [diff] [review]
patch

Review of attachment 689593 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/build/common.gypi
@@ +189,5 @@
>        # Set ARM-v7 compilation flags
>        'armv7%': 0,
>  
>        # Set Neon compilation flags (only meaningful if armv7==1).
> +      'arm_neon%': 0,

This can be overridden without changing the source (the '%' suffix).  If this needs to be un-set, please do so via either configure.in (if it depends on something configure tests, which I suspect it does), or set it in media/webrtc/webrtc_config.gypi (perhaps conditionally).

If the logic that uses arm_neon is incorrect (needs to test something else, etc), please instead provide a patch for that.

Comment 3

[StevenLee[:slee]]

Attachment: patch v2

Only when "armv7" is true, we check the value of "arm_neon."

Comment 4

[StevenLee[:slee]]

Attachment: patch v2

rebase.
Try server log,
* try: -b do -p all -u none -t none
** https://tbpl.mozilla.org/?tree=Try&rev=e123d87ad9be

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0f599b93f34d

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0f599b93f34d