819264 - Need a Policy & Mechanism for Audio Competing & Control (Patch-0 follow-up)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Comment 1

[Gene Lian (I already quit Mozilla)]

This is absolutely a bb+ because it blocks bug 805333 which is a P1 bb+.

Comment 2

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

.concat() does not change the existing arrays, but returns a new array, containing the values of the joined arrays.

Comment 3

[Gene Lian (I already quit Mozilla)]

Hi Jonas,

Thanks for your super quick review!

May I have your bb+ so that we can make the check-in process simpler? Or should I ask another check-in approval for aurora/beta? I'm fine with that too. :)

Comment 4

[Marco Chen [:mchen]]

Thanks Gene. Good catch.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/da39c8eae212

Comment 6

[Alex Keybl [:akeybl]]

(In reply to Gene Lian [:gene] from comment #3)
> Hi Jonas,
> 
> Thanks for your super quick review!
> 
> May I have your bb+ so that we can make the check-in process simpler? Or
> should I ask another check-in approval for aurora/beta? I'm fine with that
> too. :)

Please uplift this remaining audio policy work today.

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

https://hg.mozilla.org/mozilla-central/rev/c6970a82a686

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/da39c8eae212

Comment 9

[Gene Lian (I already quit Mozilla)]

Although this fix is trivial and should have no harm at all but I still receive some e-mails:

  Talos Regression Trace Malloc MaxHeap increase 0.xxx%

I guess maybe using

  array.push.apply(...)

instead of

  array = array.concat(...)

would help because the former won't create a new array on heap?

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

https://hg.mozilla.org/releases/mozilla-aurora/rev/49b847acea24
https://hg.mozilla.org/releases/mozilla-beta/rev/9b5e8d6a48d6

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Gene: I suspect that's just random noise. It seems very unlikely that this bug would have performance implications.