819399 - Add b2g OS_TARGET to source/config/writemozinfo.py

Status: RESOLVED FIXED

(Testing :: XPCShell Harness, defect)

Description

[Andrew Halberstadt [:ahal]]

For B2G we need to pass in {'os': 'gonk'} to the manifests since mozinfo isn't smart enough to handle emulators/devices yet.

Comment 1

[(not currently active) Ted Mielczarek]

We already have this:
http://mxr.mozilla.org/mozilla-central/source/config/writemozinfo.py

This is the script that writes out the mozinfo.json we use in the xpcshell harness. You should just make it write the correct value.

Comment 2

[Andrew Halberstadt [:ahal]]

Ah cool. I was wondering where the "android" was being defined. Looks like we can disable tests without any patch using 'toolkit == "gonk"'

Though we should probably add the OS_TARGET for b2g to the known_os list anyway.

Comment 3

[Andrew Halberstadt [:ahal]]

<ted> what's OS_TARGET in a b2g build, gonk?
<ahal> ted: I have no idea
<ted> $ make -sC objdir-gecko/ echo-variable-OS_TARGET
<ted> Android
<ted> that's not fantastic
<ahal> ouch
<ahal> ted: yeah, we'll need to do something about that
<ted> ahal: i'd be fine with setting os="b2g" if toolkit==gonk
<ahal> ted: yeah, that's what I ended up doing for reftests too

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Add b2g to known_os

Comment 5

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7297d8f6c6af

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7297d8f6c6af

Comment 7

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c335d671fc17
https://hg.mozilla.org/releases/mozilla-b2g18/rev/cbe115a9a488