Closed Bug 819399 Opened 8 years ago Closed 8 years ago

Add b2g OS_TARGET to source/config/writemozinfo.py

Categories

(Testing :: XPCShell Harness, defect)

Product:
Testing
Component:
XPCShell Harness
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox19 fixed, firefox20 fixed, b2g18 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla20
Tracking Flags:
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

Details

Attachments

(1 file)

Patch 1.0 - Add b2g to known_os
1.03 KB, patch
ted
: review+
Details | Diff | Splinter Review 
For B2G we need to pass in {'os': 'gonk'} to the manifests since mozinfo isn't smart enough to handle emulators/devices yet.
We already have this:
http://mxr.mozilla.org/mozilla-central/source/config/writemozinfo.py

This is the script that writes out the mozinfo.json we use in the xpcshell harness. You should just make it write the correct value.
Ah cool. I was wondering where the "android" was being defined. Looks like we can disable tests without any patch using 'toolkit == "gonk"'

Though we should probably add the OS_TARGET for b2g to the known_os list anyway.
<ted> what's OS_TARGET in a b2g build, gonk?
<ahal> ted: I have no idea
<ted> $ make -sC objdir-gecko/ echo-variable-OS_TARGET
<ted> Android
<ted> that's not fantastic
<ahal> ouch
<ahal> ted: yeah, we'll need to do something about that
<ted> ahal: i'd be fine with setting os="b2g" if toolkit==gonk
<ahal> ted: yeah, that's what I ended up doing for reftests too
Summary: Add ability to pass arbitrary metadata to xpcshell manifests → Add b2g OS_TARGET to source/config/writemozinfo.py
Attachment #690890 - Flags: review?(mdas) → review?(ted)
Attachment #690890 - Flags: review?(ted) → review+
Whiteboard: [automation-needed-in-aurora][automation-needed-in-beta]
https://hg.mozilla.org/mozilla-central/rev/7297d8f6c6af
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Whiteboard: [automation-needed-in-aurora][automation-needed-in-beta] → [automation-needed-in-aurora][automation-needed-in-beta][automation-needed-in-b2g18]
Whiteboard: [automation-needed-in-aurora][automation-needed-in-beta][automation-needed-in-b2g18] → [automation-needed-in-aurora][automation-needed-in-b2g18]
Whiteboard: [status-b2g18:fixed]
status-b2g18: --- → fixed
Whiteboard: [status-b2g18:fixed]
You need to log in before you can comment on or make changes to this bug.