Closed Bug 819412 Opened 12 years ago Closed 12 years ago

Intermittent test_bug767779.html | Test 15 animated-gif2.gif width correct - got 0, expected 40

Categories

(Core :: Graphics: ImageLib, defect)

Product:
Core
Component:
Graphics: ImageLib
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla20

People

(Reporter: emorley, Assigned: unusualtears)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 2 obsolete files)

Prepared for checkin
1.16 KB, patch
Details | Diff | Splinter Review 
Rev3 Fedora 12 mozilla-inbound debug test mochitest-4 on 2012-12-05 09:38:12 PST for push 33292b24d5d2

slave: talos-r3-fed-064

https://tbpl.mozilla.org/php/getParsedLog.php?id=17636289&tree=Mozilla-Inbound

{
12876 INFO TEST-START | /tests/image/test/mochitest/test_bug767779.html
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80040111: file ../../../../toolkit/components/mediasniffer/nsMediaSniffer.cpp, line 81
12877 ERROR TEST-UNEXPECTED-FAIL | /tests/image/test/mochitest/test_bug767779.html | Test 15 animated-gif2.gif width correct - got 0, expected 40
++DOMWINDOW == 20 (0xd13e8f8) [serial = 817] [outer = 0xbdf6ae8]
++DOMWINDOW == 21 (0xc50f668) [serial = 818] [outer = 0xd3cb448]
JavaScript error: chrome://browser/content/tabbrowser.xml, line 2023: aTab is null
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004003: file ../../../../intl/uconv/src/nsCharsetConverterManager.cpp, line 301
--DOCSHELL 0xd588ba0 == 6 [id = 240]
--DOMWINDOW == 20 (0xc50f668) [serial = 818] [outer = 0xd3cb448] [url = http://mochi.test:8888/tests/image/test/mochitest/bug733553-informant.sjs?16]
--DOMWINDOW == 19 (0xabd2d98) [serial = 812] [outer = 0xd3cb448] [url = http://mochi.test:8888/tests/image/test/mochitest/bug733553-informant.sjs?10]
--DOMWINDOW == 18 (0xc2b4c70) [serial = 813] [outer = 0xd3cb448] [url = http://mochi.test:8888/tests/image/test/mochitest/bug733553-informant.sjs?11]
--DOMWINDOW == 17 (0xcc85560) [serial = 814] [outer = 0xd3cb448] [url = http://mochi.test:8888/tests/image/test/mochitest/bug733553-informant.sjs?12]
--DOMWINDOW == 16 (0xc260ec8) [serial = 815] [outer = 0xd3cb448] [url = http://mochi.test:8888/tests/image/test/mochitest/bug733553-informant.sjs?13]
--DOMWINDOW == 15 (0xcab6890) [serial = 816] [outer = 0xd3cb448] [url = http://mochi.test:8888/tests/image/test/mochitest/bug733553-informant.sjs?14]
--DOMWINDOW == 14 (0xd3cb498) [serial = 800] [outer = (nil)] [url = http://mochi.test:8888/tests/image/test/mochitest/bug733553-informant.sjs?16]
12878 INFO TEST-PASS | /tests/image/test/mochitest/test_bug767779.html | Reference snapshot shouldn't match clean (non-image) snapshot
12879 INFO TEST-PASS | /tests/image/test/mochitest/test_bug767779.html | Reference image should disappear when it becomes display:none
12880 INFO TEST-PASS | /tests/image/test/mochitest/test_bug767779.html | Animated image looks correct, at poll #3
12881 INFO TEST-END | /tests/image/test/mochitest/test_bug767779.html | finished in 5124ms
12882 INFO TEST-START | /tests/image/test/mochitest/test_bug89419-1.html
}
Attached patch Fix test_bug733553.html (obsolete) — — Splinter Review 
Looking at this, two things jump out:

1. Bug 733553 test 15 fails, not bug 767779, but it comes when the former should be over.
2. Pulling a few recent success logs of mochitest-4, that test didn't run.

So in test_bug733553.html we quit when:

> if ((testParts.length - 1) == testIndex)

|testParts.length == 16|, so we quit when |testIndex == 15|

But in bug733553.sjs we quit when |bodyParts.length == bodyPartIndex|.  That's |16 == bodyPartIndex|.

Off-by-one error.  So when test_bug733553.html sends its last note to send a part, it quits after test 14 runs.  But the |img| load listener must still exist for a brief time, hence test for bug 767779 begins, the old test still tries to run and fails.

This patch has test_bug733553.html call |finish()| after |testIndex == 16|, so the html/sjs are in sync.

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=0f3f3c0d11b9
Assignee: nobody → unusualtears
Status: NEW → ASSIGNED
Attachment #689927 - Flags: review?(joe)
Last patch ran into the same problem, only this time with an invalid index.

This version removes the event listener, so even if it tries to keep loading, it can't run another test.

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=2d1b7ebf84a5
Attachment #689927 - Attachment is obsolete: true
Attachment #689927 - Flags: review?(joe)
Attachment #690053 - Flags: review?(joe)
Comment on attachment 690053 [details] [diff] [review]
Avoid running any tests when we call finish.

Review of attachment 690053 [details] [diff] [review]:
-----------------------------------------------------------------

Poor coding on my part! Thanks for the fix.
Attachment #690053 - Flags: review?(joe) → review+
Successful try at:
https://tbpl.mozilla.org/?tree=Try&rev=2d1b7ebf84a5
Attachment #690053 - Attachment is obsolete: true
Thanks, Joe!
Keywords: checkin-needed
This seems to happen quite frequently at the same time as bug 787312.
https://hg.mozilla.org/mozilla-central/rev/2ce14c9551fa
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: