Closed
Bug 819429
Opened 13 years ago
Closed 13 years ago
broken CA edit trust dialog
Categories
(Core Graveyard :: Security: UI, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: cviecco, Assigned: cviecco)
Details
(Keywords: regression)
Attachments
(3 files)
nightly-broken-linux
This a regression on mozilla central, on linux (ubuntu 12.04 x86_64) and osx 64. (aurora is OK)
The edit trust for a ca dialog does not show the current trust bits.
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Updated•13 years ago
|
Keywords: regression
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → cviecco
|
|
Assignee | |
Comment 2•13 years ago
|
||
Regression was here. The fix: we should not check for validity of a value we actually never use.
http://hg.mozilla.org/mozilla-central/diff/57e047e64019/security/manager/ssl/src/nsNSSCertificateDB.cpp
Attachment #690545 -
Flags: review?(bsmith)
|
|
||
Comment 3•13 years ago
|
||
Comment on attachment 690545 [details] [diff] [review]
bug-fix-1
Review of attachment 690545 [details] [diff] [review]:
-----------------------------------------------------------------
Specifically, the regression is here:
http://hg.mozilla.org/mozilla-central/rev/57e047e64019#l15.97
I did not read the code carefully enough when I modified the parameter checking.
This regression landed only on mozilla-central so no need to backport.
Thanks Camilo!
Attachment #690545 -
Flags: review?(bsmith) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Target Milestone: --- → mozilla20
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•9 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•