Closed Bug 819429 Opened 7 years ago Closed 7 years ago

broken CA edit trust dialog

Categories

(Core Graveyard :: Security: UI, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla20

People

(Reporter: cviecco, Assigned: cviecco)

Details

(Keywords: regression)

Attachments

(3 files)

Attached image nightly-broken-linux
This a regression on mozilla central, on linux (ubuntu 12.04 x86_64) and osx 64. (aurora is OK)

The edit trust for a ca dialog does not show the current trust bits.
Attached image aurora-ok-expected
Assignee: nobody → cviecco
Attached patch bug-fix-1Splinter Review
Regression was here. The fix: we should not check for validity of a value we actually never use.

http://hg.mozilla.org/mozilla-central/diff/57e047e64019/security/manager/ssl/src/nsNSSCertificateDB.cpp
Attachment #690545 - Flags: review?(bsmith)
Comment on attachment 690545 [details] [diff] [review]
bug-fix-1

Review of attachment 690545 [details] [diff] [review]:
-----------------------------------------------------------------

Specifically, the regression is here:
http://hg.mozilla.org/mozilla-central/rev/57e047e64019#l15.97
I did not read the code carefully enough when I modified the parameter checking.

This regression landed only on mozilla-central so no need to backport.

Thanks Camilo!
Attachment #690545 - Flags: review?(bsmith) → review+
Inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8be8785e3a7
Target Milestone: --- → mozilla20
https://hg.mozilla.org/mozilla-central/rev/d8be8785e3a7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.