Closed
Bug 819482
Opened 13 years ago
Closed 13 years ago
Remove retry code from B2G automation once bug 816216 propagates
Categories
(Testing :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla20
People
(Reporter: ahal, Assigned: mihneadb)
References
Details
Attachments
(1 file)
6.51 KB,
patch
|
ahal
:
review+
|
Details | Diff | Splinter Review |
We retry adb push at several points in B2G automation since adb sometimes freezes. Bug 816216 will fix the problem within devicemanager so these will no longer be needed:
http://mxr.mozilla.org/mozilla-central/search?string=if+retry+%3D%3D+push_attempts&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → mihneadb
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #689843 -
Flags: review?(ahalberstadt)
Reporter | ||
Comment 2•13 years ago
|
||
Comment on attachment 689843 [details] [diff] [review]
refactor b2gautomation according to new retryLimit param
Review of attachment 689843 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, but we can't land this until the other bug lands in github and gets merged to m-c.
Attachment #689843 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 3•13 years ago
|
||
No rush, just wanted to be done with it
Reporter | ||
Comment 4•13 years ago
|
||
Pushed to inbound minus the hunk in install_gecko() since that was re-written and is about to be re-written again (I get rid of the retry code in a patch I'm about to land).
https://hg.mozilla.org/integration/mozilla-inbound/rev/e75caf89e1f9
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•