Closed
Bug 819525
Opened 12 years ago
Closed 12 years ago
JS GDB pretty-printers: Don't trip over anonymous struct types
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: jimb, Unassigned)
Details
Attachments
(1 file)
|
1.75 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
In js/src/gdb/mozilla, various bits of code are not prepared for types whose .code is TYPE_CODE_STRUCT but whose .tag is None. This is a completely normal thing:
struct { int x, int y } p;
The attached patch fixes the problem.
Attachment #689873 -
Flags: review?(sphink)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 689873 [details] [diff] [review] JS GDB pretty-printers: Don't trip over tagless structs. Review of attachment 689873 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay. I didn't understand exactly what the patch was doing, so I tried it out and discovered that I have various gdb/python version compatibility problems. I hacked past those, and now I understand and this makes sense.
Attachment #689873 -
Flags: review?(sphink) → review+
|
Reporter | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/40e47d029f77
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla20
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/40e47d029f77
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•