819560 - RIL: remember the last mcc code

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Gregor Wagner [:gwagner]]

The current version falls back to Brasil as the default country if we don't have a SIM card or the RIL is not initialized. We should remember the last mcc code in the library.

Comment 1

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 2

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 689945 [details] [diff] [review]
patch

Review of attachment 689945 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/phonenumberutils/PhoneNumberUtils.jsm
@@ +40,5 @@
>        mcc = ril.voiceConnectionInfo.network.mcc;
>  
>      // Get SIM mcc or set it to mcc for Brasil
>      if (!mcc)
> +      mcc = ril.iccInfo.mcc || Services.prefs.getIntPref("ril.lastmcc");

getIntPref will throw if the pref doesn't exist.

@@ +43,5 @@
>      if (!mcc)
> +      mcc = ril.iccInfo.mcc || Services.prefs.getIntPref("ril.lastmcc");
> +
> +    if (!mcc) {
> +      dump("WARNING: Using the default country code for normalizing telephone numbers!\n");

Let's also add another warning if we use the pref version.

Comment 4

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 5

[Gregor Wagner [:gwagner]]

I think we should move this to RIL and maybe add it to nsIDOMMozMobileICCInfo.
something like
ril.voiceConnectionInfo.network.previousMcc

Comment 6

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 7

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 690586 [details] [diff] [review]
patch

Review of attachment 690586 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with those things fixed.

::: dom/network/interfaces/nsIDOMMobileConnection.idl
@@ +431,5 @@
>  
>    /**
> +   * Mobile Country Code (MCC) of previous subscriber's home network.
> +   */
> +  readonly attribute unsigned short previousMcc;

I'd call this lastKnownMcc or something. Right now it sounds like it's the previous value that the mcc has had, but in reality it can often be the same value as the mcc.

::: dom/system/gonk/RILContentHelper.js
@@ +360,5 @@
>    updateICCInfo: function updateICCInfo(srcInfo, destInfo) {
>      for (let key in srcInfo) {
>        destInfo[key] = srcInfo[key];
> +      if (key === 'mcc') {
> +        Services.prefs.setIntPref("ril.previousMcc", srcInfo[key]);

Shouldn't you also set the previousMcc property here?

Comment 8

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/22c6700c8794

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/22c6700c8794

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5d10c266fa86
https://hg.mozilla.org/releases/mozilla-b2g18/rev/91bf204e2f3f