819563 - Orangutan seems not to be working on pandas

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[William Lachance (:wlach)]

It is not clear why to me right now, but orangutan does not seem to be working as expected with the testing input driver at the moment. Drag gestures (all that I've tested so far) seem to be ignored.

This was working a few weeks ago, so I'm not sure exactly what's changed. I'll dig into this a bit more as I did before (by instrumenting gonk, and other things).

Getting orangutan gesture recognition working is a prerequisite for running eideticker against b2g. That said, this bug is independent other efforts to fix gaia/marionette on the pandaboard (e.g. bug 817730).

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

If this is an issue with the kernel module, what exactly do you see and what do you expect?

Comment 2

[William Lachance (:wlach)]

(In reply to Thomas Zimmermann from comment #1)
> If this is an issue with the kernel module, what exactly do you see and what
> do you expect?

Hard to say right now. I do see that the events are being generated/processed correctly inside the device, and the virtual touchscreen seems to have the right properties... so it's not obviously a kernel issue. I need to do some more digging inside eventhub to see what's going on.

Comment 3

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #2)
> (In reply to Thomas Zimmermann from comment #1)
> > If this is an issue with the kernel module, what exactly do you see and what
> > do you expect?
> 
> Hard to say right now. I do see that the events are being
> generated/processed correctly inside the device, and the virtual touchscreen
> seems to have the right properties... so it's not obviously a kernel issue.
> I need to do some more digging inside eventhub to see what's going on.

Did some more digging. I can see that orangutan wasn't initializing the multitouch property of the virtual input device correctly, but even after fixing that this doesn't seem to be working right. Needs more investigation still...

Comment 4

[William Lachance (:wlach)]

Ok, finally figured out the problem I think. We need an input device specification for the 720p touchscreen, otherwise gecko/gonk won't be able to know what the input events mean. I added one manually (at the suggestion of :mwu) when I was testing out orangutan, but we need to add one to the build as well.

Figuring out where the fix should go now, should have something done shortly.

Comment 5

[William Lachance (:wlach)]

Attachment: Add idc file for virtual touchscreen device on panda

Pretty trivial patch. I believe you were the one who first suggested I do this, so I'll assign this to you to review. :)

Comment 6

[William Lachance (:wlach)]

(In reply to William Lachance (:wlach) from comment #5)
> Created attachment 693481 [details] [diff] [review]
> Add idc file for virtual touchscreen device on panda
> 
> Pretty trivial patch. I believe you were the one who first suggested I do
> this, so I'll assign this to you to review. :)

I created a pull request to go along with this, for your merging pleasure: https://github.com/mozilla-b2g/android-device-panda/pull/17

Comment 7

[Michael Wu [:mwu]]

Comment on attachment 693481 [details] [diff] [review]
Add idc file for virtual touchscreen device on panda

Check this in directly if you have access - otherwise I can merge a pull request.

Comment 8

[Michael Wu [:mwu]]

Oh, nice.

I just noticed the indentation is a bit off on the new line. Can you fix that and merge?

Comment 9

[William Lachance (:wlach)]

Ok, cancelled the pull request and merged directly with indentation fix:

https://github.com/mozilla-b2g/android-device-panda/commit/0e9a89187970d6fa99930c8d9cb438b935c2337c