819670 - Web console object inspection does not handle native getters throwing very well

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Steps to reproduce:

1)  Open web console
2)  Type "document.__proto__"
3)  Click the resulting object to inspect it.

EXPECTED RESULTS: Inspection window comes up

ACTUAL RESULTS: No inspection window, and error console has:

  Timestamp: 12/8/12 10:50:11 AM
  Error: TypeError: Value does not implement interface Node.
  Source File: chrome://global/content/devtools/dbg-server.js
  Line: 641
  Timestamp: 12/8/12 10:50:11 AM
  Error: TypeError: Value does not implement interface Node.
  Source File: chrome://global/content/devtools/dbg-server.js
  Line: 641

This is because the proto chain has getter properties that will throw when called on a non-instance object.

Patch coming up to fix this.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make the console utils handle getters throwing by just reporting the property as having a getter, since the value can't be gotten.

Note that once bug 819624 lands this will be somewhat tested because there will be properties that throw on a chrome HTMLDocument (e.g. .domain).

Comment 2

[Mihai Sucan [:msucan]]

Comment on attachment 690101 [details] [diff] [review]
Make the console utils handle getters throwing by just reporting the property as having a getter, since the value can't be gotten.

Thank you for the patch! We should have a test as well. I can add one next week, if you're busy.

Comment 3

[Boris Zbarsky [:bzbarsky]]

It's not so much being busy as having no idea how to add one.  So if you're willing to, that would be great!  Though note what I said in comment 1 about this being tested at least a bit by the existing tests once bug 819624 lands (which might admittedly not be too soon).

Comment 4

[Mihai Sucan [:msucan]]

Attachment: fix + test

Added a test which checks if inspection fails for document.__proto__. Please let me know if this is sufficient. Thanks!

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 690427 [details] [diff] [review]
fix + test

Assuming the test fails without the patch, r=me

Comment 6

[Mihai Sucan [:msucan]]

(In reply to Boris Zbarsky (:bz) from comment #5)
> Comment on attachment 690427 [details] [diff] [review]
> fix + test
> 
> Assuming the test fails without the patch, r=me

It does. Thanks!

Comment 7

[Mihai Sucan [:msucan]]

Comment on attachment 690427 [details] [diff] [review]
fix + test

Landed:
https://hg.mozilla.org/integration/fx-team/rev/0101fe201aa4

Comment 8

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?rev=8a30e07815ff