819671 - [SeaMonkey] TEST-UNEXPECTED-FAIL browser_367052.js | the tab was restored without any history whatsoever

Status: ASSIGNED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Frank Wein [:mcsmurf]]

The test at http://mxr.mozilla.org/comm-central/source/mozilla/browser/components/sessionstore/test/browser_367052.js currently fails:

TEST-START | chrome://mochitests/content/browser/suite/common/tests/browser/browser_367052.js
++DOCSHELL 0xa0b8c9d0 == 53 [id = 262]
++DOMWINDOW == 162 (0xa23f4bd8) [serial = 811] [outer = (nil)]
++DOMWINDOW == 163 (0x9dc36a38) [serial = 812] [outer = 0xa23f4b88]
++DOMWINDOW == 164 (0xa1d883c8) [serial = 813] [outer = 0xa23f4b88]
TEST-PASS | chrome://mochitests/content/browser/suite/common/tests/browser/browser_367052.js | the new tab does have at least one history entry
JavaScript strict warning: resource://gre/components/nsSessionStore.js, line 2479: reference to undefined property tabData.attributes
JavaScript strict warning: resource://gre/components/nsSessionStore.js, line 2599: reference to undefined property tabData.attributes
TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_367052.js | Console message: [JavaScript Warning: "ReferenceError: reference to undefined property tabData.attributes" {file: "resource://gre/components/nsSessionStore.js" line: 2479}]
++DOMWINDOW == 165 (0x9d7993f8) [serial = 814] [outer = 0xa23f4b88]
TEST-INFO | chrome://mochitests/content/browser/suite/common/tests/browser/browser_367052.js | Console message: [JavaScript Warning: "ReferenceError: reference to undefined property tabData.attributes" {file: "resource://gre/components/nsSessionStore.js" line: 2599}]
NEXT ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/suite/common/tests/browser/browser_367052.js | the tab was restored without any history whatsoever
Stack trace:
    JS frame :: chrome://mochitests/content/browser/suite/common/tests/browser/browser_367052.js :: testTabLBLoad2 :: line 26
    native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0

TEST-PASS | chrome://mochitests/content/browser/suite/common/tests/browser/browser_367052.js | The closed blank tab wasn't added to Recently Closed Tabs

Also see Bug 724888 on this, the warnings might be related.

Comment 1

[Frank Wein [:mcsmurf]]

Of course I mean http://mxr.mozilla.org/comm-central/source/suite/common/tests/browser/browser_367052.js as the test file.

Comment 2

[Frank Wein [:mcsmurf]]

I don't know when this start happening, the oldest tbpl/tinderbox logs currently available (from the 8th of November 2012) already include this test failure.

Comment 3

[Philip Chee]

Possibly Bug 808035 - Pages opened by JavaScript in a new tab break the back button on first navigation

https://hg.mozilla.org/mozilla-central/rev/3267977b0f8a
Skip session history on loading initial <about:blank>

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Patch

Comment 5

[Philip Chee]

Bug 808035 was backed out.

Comment 6

[Philip Chee]

See Bug 825544 - Clicking on a duckduckgo result link while the page is loading prevents the result page from being recorded

Comment 7

[Frank Wein [:mcsmurf]]

Ok, guess I'll wait for the reland then before doing anything further then.

Comment 8

[Frank Wein [:mcsmurf]]

Marking dependency in case the other bug gets re-landed.