Closed Bug 819702 Opened 7 years ago Closed 7 years ago

Make MOZ_SELFHOSTEDJS more useful by fully pre-processing selfhosted.js

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: till, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [js:t])

Attachments

(1 file)

Currently, selfhosted.js gets only partly preprocessed: Only the error message names are replaced by indices, none of the processing done by js2c.py is applied to it, but all of it should be.
Whiteboard: [js:t]
Comment on attachment 690123 [details] [diff] [review]
apply de-macroization and de-constification form JS2C to selfhosted.js. r=?

Review of attachment 690123 [details] [diff] [review]:
-----------------------------------------------------------------

This patch applies macros and consts and re-outputs the combined file.

Seeing how replaceErrorMsgs writes out combined file only to have JS2C read it in again, and now this patch writes it out yet again afterwards -- could these redundant writes to disk be eliminated?

Not a big deal though since this is just a preprocessor, so r+ to not hold anything up.
Attachment #690123 - Flags: review?(shu) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1630310cc83d

The idea was to make as few changes to js2c.py as possible, as we imported that from V8. I guess at this point we should consider merging the functionality we need from it into our main script instead, but this isn't the bug for that.
https://hg.mozilla.org/mozilla-central/rev/1630310cc83d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.