819702 - Make MOZ_SELFHOSTEDJS more useful by fully pre-processing selfhosted.js

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Till Schneidereit [:till]]

Currently, selfhosted.js gets only partly preprocessed: Only the error message names are replaced by indices, none of the processing done by js2c.py is applied to it, but all of it should be.

Comment 1

[Till Schneidereit [:till]]

Attachment: apply de-macroization and de-constification form JS2C to selfhosted.js. r=?

Comment 2

[Shu-yu Guo [:shu]]

Comment on attachment 690123 [details] [diff] [review]
apply de-macroization and de-constification form JS2C to selfhosted.js. r=?

Review of attachment 690123 [details] [diff] [review]:
-----------------------------------------------------------------

This patch applies macros and consts and re-outputs the combined file.

Seeing how replaceErrorMsgs writes out combined file only to have JS2C read it in again, and now this patch writes it out yet again afterwards -- could these redundant writes to disk be eliminated?

Not a big deal though since this is just a preprocessor, so r+ to not hold anything up.

Comment 3

[Till Schneidereit [:till]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1630310cc83d

The idea was to make as few changes to js2c.py as possible, as we imported that from V8. I guess at this point we should consider merging the functionality we need from it into our main script instead, but this isn't the bug for that.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1630310cc83d