819714 - Take away the nice things from desktop builds

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

We've been trying to keep desktop on life support while it uses out-of-process content, omtc, and GPU compositing on some platforms where that's not officially supported.  Time to pull the plug.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: Take away the nice things from desktop b2g builds

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Additional notes
 - platform folks doing work that depends on nice things should know how to turn these things back on as needed
 - I ran into the "Mozilla black screen of death" when testing this patch with bug 819716.  Probably an existing race condition that we happen to hit.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

I applied to the patch, works great for me, first time I've seen anything but a white screen in over a month.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 690139 [details] [diff] [review]
Take away the nice things from desktop b2g builds

Review of attachment 690139 [details] [diff] [review]:
-----------------------------------------------------------------

sniff

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

This now blocks a blocker.

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

https://hg.mozilla.org/integration/mozilla-inbound/rev/65186454c480

Comment 7

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Chris, late last night I did a mozilla-beta build (rev 3fcae8234ba9 + this patch) and b2g-desktop still launches into "mozilla" and then a blank screen, on Ubuntu-12.04 in VMWare 9.

Comment 8

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

That was with gaia revision c2c9bc9875e3a85b860219f752df8894277fc938.

Comment 9

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: console log for previous failure

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Suspicious-looking things here

JavaScript error: app://system.gaiamobile.org/js/bluetooth.js, line 36: bluetooth is undefined
JavaScript error: app://system.gaiamobile.org/js/wifi.js, line 52: wifiManager is undefined

This might be a recent regression that's breaking the system app on startup.

XXX FIXME : Got a mozContentEvent: system-message-listener-ready
************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/FileUtils.jsm :: FileUtils_getDir :: line 63"  data: no]
************************************************************

I have no idea what this error is.

Comment 11

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I have a working local build.  In it, I see the first set of errors but not the second.  So that seems likely to be the problem.

Comment 12

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

bluetooth might be undefined if you're not building with --enable-b2g-bt.

Comment 13

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #12)
> bluetooth might be undefined if you're not building with --enable-b2g-bt.

I think one cannot build b2g-desktop with --enable-b2g-bt:

/home/hacker/b2g-desktop/src/dom/bluetooth/BluetoothUnixSocketConnector.cpp:30:33: fatal error: bluetooth/bluetooth.h: No such file or directory

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/65186454c480

Comment 15

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

(In reply to Brian Smith (:bsmith) from comment #13)
> (In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #12)
> > bluetooth might be undefined if you're not building with --enable-b2g-bt.
> 
> I think one cannot build b2g-desktop with --enable-b2g-bt:
> 
> /home/hacker/b2g-desktop/src/dom/bluetooth/BluetoothUnixSocketConnector.cpp:
> 30:33: fatal error: bluetooth/bluetooth.h: No such file or directory

b2g-bluetooth was mostly developed on b2g-desktop, since android and linux both used bluez/dbus through android 4.1 (Android now has its own stack :| ). You just need the libbluetooth-dev package. I'll try to get that added to the wiki.

Comment 16

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 690139 [details] [diff] [review]
Take away the nice things from desktop b2g builds

[Approval Request Comment]
Bug caused by (feature/regressing bug #): multiple bugs
User impact if declined: Many users won't be able to run the B2G desktop builds that most closely resemble the first Firefox OS release, including localizers localizing B2G and app developers developing apps for it.
Testing completed: Various folks have tested this patch (and similar ones) and reported success running B2G Desktop with it.
Risk to taking this patch (and alternatives if risky): This only affects desktop builds, which are already pretty broken (hence the patch), so it isn't very risky.
String or UUID changes made by this patch: None.

Comment 17

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 690139 [details] [diff] [review]
Take away the nice things from desktop b2g builds

b2g-only bb+ bug, no explicit approval needed (yet).

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/77b1dc0a13f8
https://hg.mozilla.org/releases/mozilla-b2g18/rev/17041e392ea6